server,sql,kv: various context improvements #72836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
miretskiy
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 2 of 4 files at r2, 1 of 1 files at r3, 1 of 1 files at r4.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @gh-casper and @RaduBerinde)
|
LGTM on the kv change. |
|
TFYRs! bors r=miretskiy,tbg |
|
Build failed: |
Merged
|
bors r=miretskiy,tbg |
|
bors r- |
|
Canceled. |
|
bors r=miretskiy,tbg |
|
bors r- |
|
Canceled. |
Needed to be able to do `AddTags(..., FromContext(ctx))` when the ctx might not have tags yet. Release note: None
In my previous changes to these areas, I mistakenly used `WithTags`, where we really wanted `AddTags`. This patch fixes that. Release note: None
Release note: None
Release note: None
Release note: None
|
bors r=miretskiy,tbg |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #58938.
Connects more async goroutines to the tracer.
Also fixes various defects I introduced in #72638 and #72605.