Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: disable BlockPropertyCollectors for SSTWriter #73765

Merged
merged 1 commit into from
Dec 14, 2021

Commits on Dec 13, 2021

  1. storage: disable BlockPropertyCollectors for SSTWriter

    There is a todo to enable it for MakeIngestionSSTWriter,
    which will require plumbing either the cluster version
    or a reference to the Engine to the function, so one can
    determine that it is safe to do so.
    Without this change, tests that mix Pebble old and new
    versions fail because old versions cannot parse sstable
    index entries containing block properties.
    
    Fixes cockroachdb#73485,cockroachdb#73708
    
    Release note: None
    sumeerbhola committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    1a8fb57 View commit details
    Browse the repository at this point in the history