Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: disable BlockPropertyCollectors for SSTWriter #73765

Merged
merged 1 commit into from
Dec 14, 2021
Merged

storage: disable BlockPropertyCollectors for SSTWriter #73765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/storage/sst_writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ func (noopSyncCloser) Close() error {
// are typically only ever iterated in their entirety.
func MakeBackupSSTWriter(f io.Writer) SSTWriter {
opts := DefaultPebbleOptions().MakeWriterOptions(0)
// Don't need BlockPropertyCollectors for backups.
opts.BlockPropertyCollectors = nil
opts.TableFormat = sstable.TableFormatRocksDBv2

// Disable bloom filters since we only ever iterate backups.
Expand All @@ -75,6 +77,10 @@ func MakeBackupSSTWriter(f io.Writer) SSTWriter {
// format set to RocksDBv2.
func MakeIngestionSSTWriter(f writeCloseSyncer) SSTWriter {
opts := DefaultPebbleOptions().MakeWriterOptions(0)
// TODO(sumeer): we should use BlockPropertyCollectors here if the cluster
// version permits (which is also reflected in the store's roachpb.Version
// and pebble.FormatMajorVersion).
opts.BlockPropertyCollectors = nil
opts.TableFormat = sstable.TableFormatRocksDBv2
opts.MergerName = "nullptr"
sst := sstable.NewWriter(f, opts)
Expand Down