sql: fix small race in distIndexBackfiller #75857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a small race condition in distIndexBackfiller. updateJobDetails calls SetResumeSpansInJob which mutates the ResumeSpanList in the job details. Normally, this is only called from the periodic updater. However, when the testing knob AlwasyUpdateIndexBackfillDetails is set, we also update it on every ProducerMetadata message we get back Release note: None
|
This change is |
adityamaru
approved these changes
Feb 2, 2022
This is another small data race in distIndexBackfill. This code was operating on mu.updatedTodoSpans (without holding the lock) instead of the copy that we created a few lines above (while holding the lock). Release note: None
|
@adityamaru Apologies, I pushed another commit for another race that I found when iterating. Mind taking another look? For the curious, these are only surfacing now because we happened to write a test that, for |
|
Ah nice catch again, LGTM! |
|
bors r=adityamaru |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small race condition in
distIndexBackfiller. updateJobDetails calls SetResumeSpansInJob which
mutates the ResumeSpanList in the job details. Normally, this is only
called from the periodic updater. However, when the testing knob
AlwasyUpdateIndexBackfillDetails is set, we also update it on every
ProducerMetadata message we get back
Release note: None