Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: fix small race in distIndexBackfiller #75857

Merged
merged 2 commits into from
Feb 2, 2022
Merged

sql: fix small race in distIndexBackfiller #75857

merged 2 commits into from
Feb 2, 2022

Commits on Feb 2, 2022

  1. sql: fix small race in distIndexBackfiller 

    This fixes a small race condition in
distIndexBackfiller. updateJobDetails calls SetResumeSpansInJob which
mutates the ResumeSpanList in the job details.  Normally, this is only
called from the periodic updater.  However, when the testing knob
AlwasyUpdateIndexBackfillDetails is set, we also update it on every
ProducerMetadata message we get back

Release note: None
    @stevendanna
    stevendanna committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    4969711 View commit details
    Browse the repository at this point in the history

  2. sql: fix a small race in distIndexBackfill 

    This is another small data race in distIndexBackfill. This code was
operating on mu.updatedTodoSpans (without holding the lock) instead of
the copy that we created a few lines above (while holding the lock).

Release note: None
    @stevendanna
    stevendanna committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    b994851 View commit details
    Browse the repository at this point in the history