cliccl: remove the debug backup commands #88338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
reviewed
Sep 21, 2022
| } | ||
|
|
||
| codec := keys.TODOSQLCodec | ||
| entry, err := backupccl.MakeBackupTableEntry( |
There was a problem hiding this comment.
I think this function can go from backupccl now too, which is has been the "ugh, why am I maintaining this" edge lately.
dt
approved these changes
Sep 21, 2022
stevendanna
force-pushed
the
ssd/remove-debug-backup
branch
from
ce7979c
to
b1c3f91
Compare
|
bors r=dt |
|
Merge conflict. |
These commands have been experimental and undocumented since their original development. Many of the commands provide the same functionality as "SHOW BACKUP". The export command provides unique functionality, but it is hard to use correctly. Further, leaving these in the code has forced us to maintain APIs in the backupccl code that we would have otherwised removed or refactored. Release justification: Low risk removal of unsupported functionality. Release note (cli change): The previously-experimental and undocumented `debug backup` has been removed.
stevendanna
force-pushed
the
ssd/remove-debug-backup
branch
from
b1c3f91
to
5974d17
Compare
|
bors r=dt |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
andreimatei
added a commit
to andreimatei/cockroach
that referenced
this pull request
Nov 18, 2022
We had code protecting us against a cli test attempting to start a tenant but discovering that the binary does not have enough ccl code linked in to do that. The code was silently skipping the test in this case. This code is no longer necessary because no test hits it. When it was introduced, I think there was a ccl test hitting it, but I believe that went away in cockroachdb#88338. This patch removes the protection. This patch is part of a larger effort to remove such silent skipping. Release note: None Epic: None
craig bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
92138: cli: remove useless test skip r=andreimatei a=andreimatei We had code protecting us against a cli test attempting to start a tenant but discovering that the binary does not have enough ccl code linked in to do that. The code was silently skipping the test in this case. This code is no longer necessary because no test hits it. When it was introduced, I think there was a ccl test hitting it, but I believe that went away in #88338. This patch removes the protection. This patch is part of a larger effort to remove such silent skipping. Release note: None Epic: None 92152: tracing/collector: don't import CCL code for no reason r=andreimatei a=andreimatei The collector test was importing ccl for no apparent reason. Release note: None Epic: None Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commands have been experimental and undocumented since their original development. Many of the commands provide the same functionality as "SHOW BACKUP". The export command provides unique functionality, but it is hard to use correctly.
Further, leaving these in the code has forced us to maintain APIs in the backupccl code that we would have otherwised removed or refactored.
Release justification: Low risk removal of unsupported functionality.
Release note (cli change): The previously-experimental and undocumented
debug backuphas been removed.