cli: remove useless test skip #92138
Merged
+0
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
We had code protecting us against a cli test attempting to start a tenant but discovering that the binary does not have enough ccl code linked in to do that. The code was silently skipping the test in this case. This code is no longer necessary because no test hits it. When it was introduced, I think there was a ccl test hitting it, but I believe that went away in cockroachdb#88338. This patch removes the protection. This patch is part of a larger effort to remove such silent skipping. Release note: None Epic: None
andreimatei
force-pushed
the
upgrades.tests.cli-skip
branch
from
b9dc2c8
to
5fa2f8b
Compare
ajstorm
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Agreed, this is old stale code.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)
andreimatei
commented
Nov 18, 2022
There was a problem hiding this comment.
bors r+
Reviewable status:
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had code protecting us against a cli test attempting to start a tenant but discovering that the binary does not have enough ccl code linked in to do that. The code was silently skipping the test in this case. This code is no longer necessary because no test hits it. When it was introduced, I think there was a ccl test hitting it, but I believe that went away in #88338. This patch removes the protection.
This patch is part of a larger effort to remove such silent skipping.
Release note: None
Epic: None