Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachprod: improve error in ParallelE #91119

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

tbg
Copy link
Member

@tbg tbg commented Nov 2, 2022

Prior to this commit, the error's stack trace did not link back
to the caller of ParallelE. Now it does.

Epic: none
Release note: None

Prior to this commit, the error's stack trace did not link back
to the caller of `ParallelE`. Now it does.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg tbg marked this pull request as ready for review November 2, 2022 04:06
@tbg tbg requested a review from a team as a code owner November 2, 2022 04:06
@tbg tbg requested review from herkolategan and renatolabs and removed request for a team November 2, 2022 04:06
Copy link
Contributor

@smg260 smg260 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @herkolategan and @renatolabs)

@tbg
Copy link
Member Author

tbg commented Nov 2, 2022

bors r=smg260

@craig
Copy link
Contributor

craig bot commented Nov 3, 2022

This PR was included in a batch that timed out, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Nov 3, 2022

Build succeeded:

@craig craig bot merged commit 9c9d55d into cockroachdb:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants