Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachprod: improve error in ParallelE #91119

Merged
merged 1 commit into from
Nov 3, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/roachprod/install/cluster_synced.go
Original file line number Diff line number Diff line change
Expand Up @@ -2282,7 +2282,11 @@ func (c *SyncedCluster) ParallelE(
}

if len(failed) > 0 {
return failed, errors.New("one or more parallel execution failure")
var err error
for _, res := range failed {
err = errors.CombineErrors(err, res.Err)
}
return nil, errors.Wrap(err, "parallel execution failure")
}
return nil, nil
}
Expand Down