Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: release: fix bincheck failures #95039

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

rail
Copy link
Member

@rail rail commented Jan 11, 2023

Backport 1/1 commits from #94975.

/cc @cockroachdb/release


Previously, the bincheck test started failing after upgrading the linux build system to a newer GLIBC and after we changed the way we stop the server.

The linux bincheck test was relying on running the cockroach binary in a qemu-based VM, using a custom kernel.

Now that, we don't use rocksdb and don't have SSE issues (see #15589), we can simplify the test and run the binary without the VM layer.

This PR also fixes the issue, where the busybox kill command can only handle positional arguments.

We try our best to kill the server, but in some cases the PID changes and the whole test fail. Ignore the kill exit code and let the build agent to kill the process.

Epic: none
Fixes: RE-271
Release note: None
Release justification: release automation fix

Previously,  the bincheck test started failing after upgrading the linux
build system to a newer GLIBC and after we changed the way we stop the
server.

The linux bincheck test was relying on running the cockroach binary in a
qemu-based VM, using a custom kernel.

Now that, we don't use rocksdb and don't have SSE issues (see cockroachdb#15589),
we can simplify the test and run the binary without the VM layer.

This PR also fixes the issue, where the busybox `kill` command can only
handle positional arguments.

We try our best to kill the server, but in some cases the PID changes
and the whole test fail. Ignore the kill exit code and let the build
agent to kill the process.

Epic: none
Fixes: RE-271
Release note: None
@rail rail requested a review from celiala January 11, 2023 03:03
@rail rail requested a review from a team as a code owner January 11, 2023 03:03
@rail rail self-assigned this Jan 11, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jan 11, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rail rail merged commit d91d145 into cockroachdb:release-22.2 Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants