release-22.2: release: fix bincheck failures #95039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #94975.
/cc @cockroachdb/release
Previously, the bincheck test started failing after upgrading the linux build system to a newer GLIBC and after we changed the way we stop the server.
The linux bincheck test was relying on running the cockroach binary in a qemu-based VM, using a custom kernel.
Now that, we don't use rocksdb and don't have SSE issues (see #15589), we can simplify the test and run the binary without the VM layer.
This PR also fixes the issue, where the busybox
kill
command can only handle positional arguments.We try our best to kill the server, but in some cases the PID changes and the whole test fail. Ignore the kill exit code and let the build agent to kill the process.
Epic: none
Fixes: RE-271
Release note: None
Release justification: release automation fix