Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: release: fix bincheck failures #95039

Merged
merged 1 commit into from
Jan 11, 2023

Commits on Jan 11, 2023

  1. release: fix bincheck failures

    Previously,  the bincheck test started failing after upgrading the linux
    build system to a newer GLIBC and after we changed the way we stop the
    server.
    
    The linux bincheck test was relying on running the cockroach binary in a
    qemu-based VM, using a custom kernel.
    
    Now that, we don't use rocksdb and don't have SSE issues (see cockroachdb#15589),
    we can simplify the test and run the binary without the VM layer.
    
    This PR also fixes the issue, where the busybox `kill` command can only
    handle positional arguments.
    
    We try our best to kill the server, but in some cases the PID changes
    and the whole test fail. Ignore the kill exit code and let the build
    agent to kill the process.
    
    Epic: none
    Fixes: RE-271
    Release note: None
    rail committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    76a39ab View commit details
    Browse the repository at this point in the history