Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.5.6 Ready code #9345

Merged
merged 155 commits into from
Dec 28, 2024
Merged

4.5.6 Ready code #9345

merged 155 commits into from
Dec 28, 2024

Conversation

paulbalandan
Copy link
Member

No description provided.

kenjis and others added 30 commits September 6, 2024 13:53
@kenjis
docs: fix param types
3dfd4bc
@kenjis
docs: decorate text
2ef57ab
@kenjis
docs: add changelog and upgrade for v4.5.6
b5b2e57
@kenjis
docs: add note
ee9ae5f
@kenjis
docs: move item
2492078
@kenjis
docs: move section
cb4ba98
@kenjis
docs: use GitHub markdown note format
d7bedff
@kenjis
Merge pull request #9175 from kenjis/docs-changelog-4.5.6
ce7f591 
docs: add changelog and upgrade for v4.5.6
@kenjis
Merge pull request #9171 from kenjis/docs-url_helper.rst
268156c 
docs: improve url_helper.rst
@kenjis
Merge pull request #9176 from kenjis/update-RELEASE.md
0a6b39d 
docs: update RELEASE.md
@kenjis
docs: improve description for Migration File Names
22cf15e
@kenjis
docs: add link to section
7113792
@kenjis
docs: fix typo
e53c32c
@kenjis
fix: auto_link() converts invalid string like "://codeigniter.com"
791fe2f 
The scheme is missing, so it is not a valid URL.
@kenjis
refactor: break long lines
94fe31f
@kenjis
Merge pull request #9179 from kenjis/improve-migration-file-names
647f4e7 
docs: improve "Migration File Names"
@dependabot
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
3776790 
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@1.2.4...1.2.5)

---
updated-dependencies:
- dependency-name: rector/rector
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@samsonasik
Fix phpstan
0a9835b
@samsonasik
Merge pull request #9183 from codeigniter4/dependabot/composer/rector…
b678930 
…/rector-1.2.5

chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
@samsonasik
refactor: enable TypedPropertyFromAssignsRector
45a002f
@ddevsr
docs: broken link htmx ajax-header
fe65154
@samsonasik
Merge pull request #9184 from samsonasik/refactor-typed-property
092d85b 
refactor: enable TypedPropertyFromAssignsRector
@samsonasik
refactor: enable ClosureReturnTypeRector
3f29f28
@samsonasik
Fix cs
8ecbf0d
@samsonasik
Merge pull request #9187 from samsonasik/refactor-enable-closure-return
1528d3d 
refactor: enable ClosureReturnTypeRector
@kenjis
Merge pull request #9185 from ddevsr/broken-link-htmx-ajax
36f9c2f 
docs: broken link htmx ajax-header
@kenjis
docs: fix Project Files changes
7d2d81c 
See https://forum.codeigniter.com/showthread.php?tid=91656&pid=421265#pid421265
@kenjis
Merge pull request #9180 from kenjis/fix-auto_link-bug
d49d700 
fix: auto_link() converts invalid strings like `://codeigniter.com`
@kenjis
chore: update psr/log to 3.0.2
d6850d4
@kenjis
Merge pull request #9188 from kenjis/fix-upgrade_455.rst
bd3ee0f 
docs: fix Project Files changes in upgrade_455.rst
samsonasik and others added 24 commits December 11, 2024 23:48
@samsonasik
Merge pull request #9315 from paulbalandan/method-namecase
f5200b5 
refactor: fix `method.nameCase` errors
@samsonasik
Merge pull request #9314 from paulbalandan/rename-controller-to-Contr…
0b0126c 
…oller

refactor: rename `controller` to `Controller`
@paulbalandan
refactor: fix implicit array creation
c06d928
@samsonasik
Merge pull request #9316 from paulbalandan/implicit-array-creation
e9bb603 
refactor: fix implicit array creation
@michalsn @datamweb
fix: check if defined WRITEPATH exists (#9317)
9bc61b3 
* fix: check if defined WRITEPATH exists

* cs fix

* Update system/Boot.php

Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>

* cs fix

---------

Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
@ddevsr
refactor: followup style variable array (#9319)
0f5de27
@samsonasik
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicen…
94e57df 
…seRule
@samsonasik
chore: fix ci run
6644b79
@samsonasik
Merge pull request #9321 from samsonasik/chore-prepare-phpstan-2
f0536a1 
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicenseRule
@paulbalandan
refactor: split phpstan-baseline into smaller files (#9299)
242745c 
* refactor: split phpstan-baseline into smaller files

* Checkout base branch to resolve codeigniter4/framework

* Fix rector changes
@samsonasik
refactor: upgrade to use phpstan 2 and rector 2 (#9322)
61881bd
@andifahruddinakas
docs: phpdoc incorrect explanation regarding variable naming (#9326)
17f7a9d 
* Update FileHandler.php

* Update BaseConnection.php

* Update Connection.php

* Update filesystem_helper.php

* Update Security.php

* Update SecurityInterface.php
@andifahruddinakas
docs: variable naming adjustments (#9324)
cc2dcee 
* Update 006.php

* Update 008.php

* Update 046.php
@paulbalandan
refactor: fix Forge::processIndexes() for empty $this->fields (#9330
f48aa6f 
)
@neznaika0
fix: Remove DB files after tests (#9192)
ab5536f
@paulbalandan
refactor: Reflection*::setAccessible() is now no-op in PHP 8.1 (#9331)
8fa419f
@paulbalandan
refactor: add @throws RedirectException in Controller::initControll…
cc1b8f2 
…er (#9327)
@michalsn
fix: handling binary data for prepared statement (#9337)
6cbbf60 
* fix prepare statement sqlite

* fix prepare statement postgre

* fix prepare statement sqlsrv

* fix prepare statement oci8

* tests

* abstract isBinary() method

* fix prepare statement mysqli

* fix prepare statement oci8

* sqlsrv blob support

* fix tests

* add changelog

* fix rector

* make sqlsrv happy

* make oci8 happy - hopefully

* add a note about options for prepared statement

* ignore PreparedQueryTest.php file

* apply code suggestion for oci8
@paulbalandan
refactor: fix warning on new static usage
2114577
@samsonasik
Merge pull request #9342 from paulbalandan/new-static
e363f47 
refactor: fix warning on new static usage
@paulbalandan
refactor: fix used void return type (#9341)
19ad2b9
@neznaika0
refactor: fix phpstan only boolean allowed (#9302)
8cff099 
* refactor: Fix `phpstan` boolean errors

* fix: Check predis response

* refactor: Improve comparison with an empty string

* dev: Update phpstan-baseline

* fix: Revert comparison with null
@samsonasik
refactor: enable instanceof and strictBooleans rector set (#9339)
ee4ee98 
* refactor: enable instanceof and strictBooleans rector set

* refactor: bump to rector 2.0.4

* refactor: clean condition check

* refactor: revert ThirdParty change

* refactor: re-run phpstan baseline

* refactor: fix never empty array on Image

* refactor: avoid repetitive call pg_last_error()

* refactor: pg_last_error() always returns string

* refactor: use return empty string on pg_last_error() got empty "0"

* refactor: various compare !== 1 on preg_match()

* refactor: use falsy check on getenv()

* refactor: more !== 1 compare on preg_match()

* refactor: use empty string check on guessExtension

* refactor: run cs fix

* refactor: more !== 1 compare on preg_match()

* use direct result of pg_last_error()

* refactor: use str_contains() over strpos on Forge

* refactor: fix unused variable

* refactor: check empty string on ResponseTrait

* refactor: more preg_match() and empty string only check

* refactor: compare to 0 on preg_match_all()

* refactor: re-run rector

* refactor: preg_match_all() likely less to return false
@paulbalandan
Prep for 4.5.6 release (#9344)
6785d8f
@paulbalandan
Copy link
Member Author

paulbalandan commented Dec 28, 2024 •
edited
Loading

I think the failures are because composer cannot find the tag ^4.5 for codeigniter4/framework within this repo. In other PRs where base branch is develop, composer correctly maps develop as 4.x-dev. However, since base branch is master, I think composer no longer has the knowledge.

Fixed in #9346

This was referenced Dec 28, 2024
Merged
Merged
@paulbalandan paulbalandan merged commit 51cdd7d into master Dec 28, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.