Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI release step for linux-arm64 #2480

Closed
jsjoeio opened this issue Dec 17, 2020 · 3 comments · Fixed by #2804
Closed

Fix CI release step for linux-arm64 #2480

jsjoeio opened this issue Dec 17, 2020 · 3 comments · Fixed by #2804
Labels
enhancement Some improvement that isn't a feature
Milestone
v3.9.1

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 17, 2020 •
edited
Loading

As discussed briefly with @code-asher, we'd like to make some improvements to the CI workflow, specifically in the release step for linux-arm64.

Problem

The ci / linux-arm64 workflow is failing at the “Run ./ci/steps/release-packages.sh build step.

Reason

The machine has no space left.

Potential Solutions

  • doing a shallow clone with the repo in the checkout step
  • delete the asset we download (if it build successfully)
  • deleting the node_modules directory on machine

Relevant
@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label Dec 17, 2020
@code-asher
Copy link
Member

We worked out this was caused by an accumulation of Docker images which was resolved by deleting them. Will need some kind of cleanup or a way to prevent this accumulation.

@jsjoeio jsjoeio mentioned this issue Feb 26, 2021
Closed
@jsjoeio jsjoeio added this to the v3.9.1 milestone Feb 26, 2021
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Feb 26, 2021 •
edited
Loading

last time i think i just added a docker rm $(docker ps -aq) to ci and ran that once then removed it lol
and a docker rmi $(docker images -q) as well i think

Potential solution.

This was referenced Feb 26, 2021
Merged
Merged
@jsjoeio jsjoeio linked a pull request Mar 1, 2021 that will close this issue
fix(ci): add step to remove docker images on linux-arm64 #2804
Merged
@greyscaled
Copy link
Contributor

Fixed in d48a74c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Milestone
v3.9.1
Development

Successfully merging a pull request may close this issue.

fix(ci): add step to remove docker images on linux-arm64 coder/code-server
3 participants
@jsjoeio @greyscaled @code-asher