Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): add step to remove docker images on linux-arm64 #2804

Merged
merged 3 commits into from
Mar 2, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Mar 1, 2021

This PR fixes #2480 .

  • add step to remove docker images on linux-arm64 ci job (thanks to @code-asher for the tip, @vapurrmaid for the refactor!)
  • add step to remove release-packages and test/videos on the test job
  • changes the extension used in test:standalone-release

I suggest changing the extension away from the Python because it's notorious for breaking in code-server. A theme extension changes less frequently and is much more reliable for testing.

@jsjoeio jsjoeio added this to the v3.9.1 milestone Mar 1, 2021
@jsjoeio jsjoeio requested a review from a team March 1, 2021 23:17
@jsjoeio jsjoeio self-assigned this Mar 1, 2021
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Mar 1, 2021

Now that's an error I haven't seen before 🤔 Doesn't look like a disk space issue which is good. I'll take a closer look.

image

@jsjoeio jsjoeio linked an issue Mar 1, 2021 that may be closed by this pull request
@jsjoeio jsjoeio marked this pull request as ready for review March 2, 2021 00:05
Comment on lines 92 to 93
- name: Prune docker images
run: docker system prune -af
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove this after it runs once. I think it just needs to do a quick cleanup and then in general, it should be enough to run it at the end!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh makes sense!

This adds a step to remove both the release packages and the test artifacts as
a step at the end of test in ci.yaml.
This adds a step to remove the docker images and hopefully free up space in the
linux-arm64 part of ci.
@jsjoeio jsjoeio removed the request for review from a team March 2, 2021 18:50
@jsjoeio jsjoeio merged commit d48a74c into master Mar 2, 2021
@jsjoeio jsjoeio deleted the jsjoeio-fix-ci-linux branch March 2, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI release step for linux-arm64
2 participants