Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(testing): add unit tests for register #2719

Merged
merged 22 commits into from
Feb 26, 2021
Merged

feat(testing): add unit tests for register #2719

merged 22 commits into from
Feb 26, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Feb 12, 2021 •
edited
Loading

This PR adds a few tests for src/browser/register.ts.

Screenshot

image

It increases our code coverage (Lines) from 50.09% to 51.13% (↑ 1.04%).
🟩 100% Line coverage (last 100) for src/browser/register.ts

image

TODOs

  • rebase branch onto master
  • address feedback
  • refactor based on Asher's suggestion
  • add test for else statement in register

@jsjoeio jsjoeio added this to the v3.8.2 milestone Feb 12, 2021
@jsjoeio jsjoeio self-assigned this Feb 12, 2021
@jsjoeio jsjoeio marked this pull request as ready for review February 12, 2021 00:04
@jsjoeio jsjoeio marked this pull request as draft February 12, 2021 16:43
@jsjoeio jsjoeio marked this pull request as ready for review February 12, 2021 17:10
oxy
oxy approved these changes Feb 12, 2021
View reviewed changes
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Your choice on if you want a second opinion from asher on this one; I'm not too confident in my TS just yet 😅

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Feb 12, 2021

I'll play it safe since we're releasing today - @code-asher would love an 👀 on this one!

@jsjoeio jsjoeio modified the milestones: v3.9.0, v3.9.1 Feb 12, 2021
jsjoeio
jsjoeio commented Feb 18, 2021
View reviewed changes
test/util.test.ts Show resolved Hide resolved
src/browser/register.ts Outdated Show resolved Hide resolved
src/browser/register.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jsjoeio jsjoeio mentioned this pull request Feb 18, 2021
Closed
@jsjoeio jsjoeio marked this pull request as draft February 18, 2021 22:17
@jsjoeio jsjoeio marked this pull request as ready for review February 18, 2021 23:57
code-asher
code-asher requested changes Feb 22, 2021
View reviewed changes
src/browser/register.ts Outdated Show resolved Hide resolved
test/emitter.test.ts Show resolved Hide resolved
test/register.test.ts Outdated Show resolved Hide resolved
test/register.test.ts Outdated Show resolved Hide resolved
test/register.test.ts Outdated Show resolved Hide resolved
src/browser/register.ts Outdated Show resolved Hide resolved
@jsjoeio jsjoeio marked this pull request as draft February 22, 2021 17:38
Base automatically changed from add-tests-emitter to master February 23, 2021 17:02
@jsjoeio jsjoeio force-pushed the add-tests-register branch 2 times, most recently from 14ad29a to 909d425 Compare February 23, 2021 23:03
@jsjoeio jsjoeio marked this pull request as ready for review February 23, 2021 23:27
jsjoeio
jsjoeio commented Feb 23, 2021
View reviewed changes
test/helpers.ts Outdated Show resolved Hide resolved
test/register.test.ts Show resolved Hide resolved
@jsjoeio
refactor: use logger in serviceworker
a9f88af
@jsjoeio
feat: test failure to register service worker
44b9874
@jsjoeio
refactor: add handleRegisterServiceWorker fn
21f577d
@jsjoeio
feat(test): add test handleRegisterServiceWorker
38891de
@jsjoeio
refactor(register): use logError instead of logger
7ef630f
@jsjoeio
refactor: use same syntax as logger spy
a44a514
@jsjoeio
refactor: use LogModule from Asher in tests
027e8e5
@jsjoeio
refactor: move loggerModule into helpers
711abd8
@jsjoeio
refactor: dont use actual logger in helper
1470ff2
@jsjoeio
refactor: hoist jest.mock in constants
1c737f1
@jsjoeio
refactor: use loggerModule in util
cb4185b
@jsjoeio
refactor: update mocking logger in register test
e6a324b
@jsjoeio
feat(register): add test when navigator undefined
b232dcb
@jsjoeio
feat: add test for catching errors in Emitter
80a1800
@jsjoeio
chore(testing): add service-worker-mock
46226ea
@jsjoeio
feat: add logs to serviceWorker
ee0973c
@jsjoeio jsjoeio requested a review from a team as a code owner February 26, 2021 19:04
code-asher
code-asher requested changes Feb 26, 2021
View reviewed changes
test/emitter.test.ts Outdated Show resolved Hide resolved
code-asher
code-asher approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

test/register.test.ts Outdated Show resolved Hide resolved
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Feb 26, 2021

CI only failed due to #2480

@jsjoeio jsjoeio merged commit 726f694 into master Feb 26, 2021
@jsjoeio jsjoeio deleted the add-tests-register branch February 26, 2021 23:47
@jsjoeio jsjoeio added the testing Anything related to testing label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxy oxy oxy approved these changes

@code-asher code-asher code-asher approved these changes

Assignees

@jsjoeio jsjoeio

Labels
testing Anything related to testing
Projects
None yet
Milestone
v3.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jsjoeio @oxy @code-asher