Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch configuring the display language #4598

Closed
jsjoeio opened this issue Dec 9, 2021 · 4 comments · Fixed by #4680
Closed

Patch configuring the display language #4598

jsjoeio opened this issue Dec 9, 2021 · 4 comments · Fixed by #4680
Assignees
@code-asher
Labels
bug Something isn't working
Milestone
4.0.1

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 9, 2021

Previously, we supported the ability to configure the Display Language. As a result of switching to VS Code's upstream server, we have lost this feature with the 4.0.0 upgrade.

Does it work upstream?

Apparently, no. If you go to vscode.dev and try to install a language pack, you get the following error messages:
image

Same with Codespaces
image

How did it work before in code-server?

I believe we had to patch it to get it to work. We can investigate readding the patch, or even submitting a patch upstream to get this functionality both in code-server and vscode.dev/Codespaces
@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label Dec 9, 2021
@jsjoeio jsjoeio added this to the 4.0.1 milestone Dec 9, 2021
@jsjoeio jsjoeio mentioned this issue Dec 9, 2021
Merged
21 tasks
@jsjoeio jsjoeio reopened this Dec 13, 2021
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 13, 2021

Didn't mean to close this!

@jsjoeio jsjoeio modified the milestones: 4.0.1, 4.0.0 Dec 13, 2021
@code-asher code-asher self-assigned this Dec 13, 2021
@code-asher code-asher added bug Something isn't working and removed enhancement Some improvement that isn't a feature labels Dec 17, 2021
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 17, 2021

We used to patch this before. @code-asher patched this previously and will push up his patch. That's a good place to look. It will be on his fork here.

@code-asher
Copy link
Member

Linked above, note that you need to make a full build to test.

@code-asher code-asher mentioned this issue Dec 22, 2021
Merged
code-asher added a commit to coder/vscode that referenced this issue Dec 23, 2021
@code-asher
Restore display language support (#34)
76663e7 
For coder/code-server#4598.
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jan 3, 2022

Fixed via coder/vscode#34

@jsjoeio jsjoeio closed this as completed Jan 3, 2022
code-asher added a commit to code-asher/code-server that referenced this issue Jan 4, 2022
@code-asher
Update VS Code
9c7c213 
Fixes coder#4598
Fixes coder#4620
Fixes coder#4600
@code-asher code-asher mentioned this issue Jan 4, 2022
Merged
code-asher added a commit that referenced this issue Jan 4, 2022
@code-asher
chore: update vscode (#4680)
f04fcf2 
* Update VS Code

Fixes #4598
Fixes #4620
Fixes #4600

* Add locale flag back

This is valid again now that we have restored display language support.
@jsjoeio jsjoeio mentioned this issue Jan 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@code-asher code-asher

Labels
bug Something isn't working
Projects
None yet
Milestone
4.0.1
Development

Successfully merging a pull request may close this issue.

chore: update vscode code-asher/code-server
2 participants
@jsjoeio @code-asher