Restore display language support #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
approved these changes
Dec 23, 2021
| const regexp = /('(?:[^\\']*(?:\\.)?)*')|('(?:[^\\']*(?:\\.)?)*')|(\/\*(?:\r?\n|.)*?\*\/)|(\/{2,}.*?(?:(?:\r?\n)|$))/g; | ||
|
|
||
| return content.replace(regexp, (match, _m1, _m2, m3, m4) => { | ||
| // Only one of m1, m2, m3, m4 matches |
There was a problem hiding this comment.
What exactly is this? I know you said taken from src/main so I guess I'll have to look there when reviewing this from a computer.
There was a problem hiding this comment.
I think the file can contain comments so they remove them since JSON.parse will choke otherwise.
| @@ -15,9 +15,10 @@ import { AuthType } from 'vs/base/common/auth'; | |||
| export const serverOptions: OptionDescriptions<ServerParsedArgs> = { | |||
| //#region @coder | |||
| 'auth': { type: 'string' }, | |||
| 'port': { type: 'string' }, | |||
| 'locale': { type: 'string' }, | |||
There was a problem hiding this comment.
Does this mean you can pass locale as a command line arg?
There was a problem hiding this comment.
Yup, gonna add it back on the code-server side.
|
Could be worth submitting upstream although it is anyone's guess whether this is the path they will end up taking! |
|
There are some things we would need to change first though. |
This was referenced Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For coder/code-server#4598.