-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 110 - Warn about required fields not being filled in in forms #143
Issue 110 - Warn about required fields not being filled in in forms #143
Conversation
This reverts commit e903fcc.
…required_fields_not_being_filled_in_in_forms
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
For the |
Btw is the callout centered? The text should be a bit more to the left I think. If the callout comes with padding or margin feel free to remove it (it's not used in anywhere else apart from component showcase I think so the display shouldn't break) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Found some bug. Cannot submit the form when fill in every field |
Change Summary
Extends the
<Form/>
component so that required fields display an error if they are left empty.Change Form
Other Information
The original ticket suggested including "(required)" in the label automatically, but I have excluded from this PR.
It consumes a lot of space and feels unnecessary, especially if most fields will be required anyway. Might be better to do the inverse and label non-required fields as "(optional)".
Related issue