Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Issue 110 - Warn about required fields not being filled in in forms" #163

Conversation

ErikaKK
Copy link
Contributor

@ErikaKK ErikaKK commented Jul 23, 2024

Reverts #143
Cannot submit the form. Can test in sign-in.tsx page
image
Can keep working on this later but I need to prioritize other pages now. Cheers!

Related issue

Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
penni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 4:32am

@allyharrison
Copy link
Collaborator

@ErikaKK it's working as expected for me image

@ErikaKK
Copy link
Contributor Author

ErikaKK commented Jul 23, 2024

Can you check if you pull and merge the latest main

Copy link
Collaborator

@allyharrison allyharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, seems like some other changes are interfering with it from after I made the PR. Gonna revert and have a look.

@allyharrison allyharrison merged commit 05735df into main Jul 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show/warn about required fields not being filled in in forms
2 participants