Skip to content
This repository has been archived by the owner on Oct 2, 2018. It is now read-only.

Support RTL languages #165

Closed
ferndot opened this issue Feb 3, 2014 · 7 comments
Closed

Support RTL languages #165

ferndot opened this issue Feb 3, 2014 · 7 comments
Assignees
@ferndot
Labels
domain: user experience priority: critical
Milestone
v0.3.2 Global Fire!

Comments

@ferndot
Copy link
Member

ferndot commented Feb 3, 2014

To support languages like Hebrew, we need to redo the stylesheets to support RTL layout.
@ghost ghost assigned ferndot Feb 3, 2014
@ferndot ferndot mentioned this issue Feb 3, 2014
Closed
@bdcomp
Copy link

bdcomp commented Feb 6, 2014

@joshua-s May I translate for now the remaining strings with html bold tags, by just removing the tags?

@ferndot
Copy link
Member Author

ferndot commented Feb 6, 2014

Of course! They were just a minor visual aid that I am starting to regret because of localization issues.

@bdcomp
Copy link

bdcomp commented Feb 6, 2014

Hebrew translation done!

@ferndot
Copy link
Member Author

ferndot commented Feb 6, 2014

👍

@ferndot
Copy link
Member Author

ferndot commented Feb 11, 2014

In 5b045d0, I made the language function assign a data-language attribute to the<body>. (may change that to add it to the <html>.) It is now possible to customize the css for each language.

Also, I am considering adding a data-direction attribute to make it easier to distinguish in the css between ltr and rtl languages.

@ferndot ferndot closed this as completed in 7c7de41 Mar 6, 2014
@bdcomp
Copy link

bdcomp commented Mar 6, 2014

Yay! I wanna try it :)

@joshua-s How about to release a new version, as there were many languages/translations related commits since the last version?

@ferndot
Copy link
Member Author

ferndot commented Mar 6, 2014

@bdcomp we are actually doing that :) I am going to move the new languages into a branch so that we can release a new version this week. We are also making a Hacks post that should come out next week (maybe Monday).

@ferndot ferndot modified the milestones: v0.3.2, v0.4 Mar 6, 2014
ferndot pushed a commit that referenced this issue Mar 6, 2014
Fix #165, Add RTL spinner, small graphical changes
5504283
ferndot pushed a commit that referenced this issue Mar 7, 2014
Turkish is not RTL (#165)
ac7fd7c
ferndot pushed a commit that referenced this issue Apr 8, 2014
Turkish is not RTL (#165)
654e450
ferndot pushed a commit that referenced this issue Apr 8, 2014
Turkish is not RTL (#165)
ed4729d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ferndot ferndot

Labels
domain: user experience priority: critical
Projects
None yet
Milestone
v0.3.2 Global Fire!
Development

No branches or pull requests
2 participants
@ferndot @bdcomp