Add validation for candidates #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pbochis
force-pushed
the
app-candidate-validation
branch
from
113347c to
30612e1
Compare
| }, | ||
| validate: function(){ | ||
| var valid = true; | ||
| //TODO: When https://github.com/PolymerElements/paper-dropdown-menu/pull/57 gets released, revisit this. |
There was a problem hiding this comment.
I just left them a comment. Releasing a new version should not be too cumbersome, maybe they are nice enough to release this in the next days.
pbochis
force-pushed
the
app-candidate-validation
branch
3 times, most recently
from
01f0c50 to
51e4f02
Compare
|
This should be merged asap. Because of this changing all the selects in the app with |
pbochis
force-pushed
the
app-candidate-validation
branch
from
51e4f02 to
234a811
Compare
|
A new version of |
pbochis
force-pushed
the
app-candidate-validation
branch
from
234a811 to
654706d
Compare
| label="Name <email>" | ||
| value="{{candidate.Address}}" | ||
| pattern="[a-zA-Z ]*<[a-z0-9!#$%&\'*+\/=?^_`{|}~-]+(?:\.[a-z0-9!#$%&\'*+\/=?^_`{|}~-]+)*@(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\.)+[a-z0-9](?:[a-z0-9-]*[a-z0-9])?>" | ||
| error-message="Incorrect format" |
There was a problem hiding this comment.
Useless message! At least give a hint on how it should look like.
pbochis
force-pushed
the
app-candidate-validation
branch
2 times, most recently
from
cbcbdd3 to
7a81485
Compare
* add validateable behaviour to `invite-candidate-input`
pbochis
force-pushed
the
app-candidate-validation
branch
from
7a81485 to
f3c7f1f
Compare
lorenzleutgeb
added a commit
that referenced
this pull request
Oct 21, 2015
Add validation for candidates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invite-candidate-input