Add candidate validation #79
Conversation
pbochis
force-pushed
the
validate-candidate
branch
from
35cf07f to
7f81639
Compare
| @@ -85,6 +103,7 @@ var util = { | |||
| } | |||
| page.redirect('/error'); | |||
| }, | |||
| emailRegex: '[a-z0-9!#$%&\'*+/=?^_`{|}~-]+(?:\.[a-z0-9!#$%&\'*+/=?^_`{|}~-]+)*@(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\.)+[a-z0-9](?:[a-z0-9-]*[a-z0-9])?', | |||
There was a problem hiding this comment.
i think you can use polymer paper-input's allowedPattern for this
There was a problem hiding this comment.
You're right, but I'd rather they do something wrong and then get a warning for it than just not being allowed to write stupid stuff and not understanding why. Remember, this form will be mostly used by non-technical people.
There was a problem hiding this comment.
pattern, not allowedPattern.
Polymer docs - A pattern to validate the input with.
|
What's up with this PR? |
| @@ -45,8 +50,8 @@ | |||
| <p>{{challenges.0.Name}}</p> | |||
| </template> | |||
| <template is="dom-if" if="{{!isSingleChallenge}}"> | |||
| <select id="challenges" on-change="_setChallenge"> | |||
| <option selected disabled>Please select a challenge</option> | |||
| <select id="challenges" class$={{selectClass}} on-change="_setChallenge"> | |||
There was a problem hiding this comment.
https://elements.polymer-project.org/elements/paper-dropdown-menu
if we use this, we shoudn't need any custom validations and css-class hacks, and iz more beautiful
There was a problem hiding this comment.
When i coded this, the paper-dropdown was not available. Changing itn ow.
|
#121 Fixes this. |
No description provided.