-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.0 crashes on MacOS (Preprocessor, Plugin), fixed on master -> Release 5.1? #518
Comments
@ryanclark @codymikol when it is planned to make the next release? The problems we have in OSMD are already resolved in the current code base. |
I know Ryan's been pretty occupied with his own obligations. When he has some time, I'm hoping to get our process for cutting releases streamlined so that we can quickly and easily cut new versions. |
By the way, paths are still broken for Windows with the current master build: Maybe something like PR #433 is still needed, even though the statement was made that relative paths were supposed to be eliminated. |
We've also experienced this issue while trying to bump webpack to v5 for our test suite, anything we can assist with to get a new release cut? |
Any update on a release that has the fix for this issue? |
Nope |
The repository was transferred to me, I'm preparing to make a 6.0.0 release that targets node 18+ |
Any updates on this issue? |
@codymikol Is there still a new release planned? Just a friendly nudge, thanks :) |
Expected Behavior
Karma-webpack doesn't crash on MacOS
Actual Behavior
Karma-webpack 5.0 throws errors and crashes on MacOS, in
karma-webpack/preprocessor.js
andwebpack/plugin.js
.Both these errors are fixed on master, but not released yet, so you'd have to patch your npm release manually to make it work on MacOS.
If you're not ready to release 5.1 yet, instead releasing an alpha/dev version on npm with the current master would be great.
Otherwise, I would have to create a prebuild script that patches in these 2 files from the master version into the node_modules/karma-webpack folders.
Since I migrated to webpack 5, I also can't use karma-webpack 4.x for now, as far as I'm aware.
You can also fix these files in 5.0 with oneliners:
In
node_modules/karma-webpack/lib/karma-webpack/preprocessor.js
,I had to replace line 96 with this:
return bundleContent;
And in
node_modules/karma-webpack/lib/webpack/plugin.js
, I had to replace line 18 with this:webpackFileObj.name.replace("../", "../../")
There is a ../ missing from the path to make it valid, the chain of
../
stops one folder before the root node/folder.How Do We Reproduce?
Probably just have a preprocessor file with 5.0 on MacOS.
Full repro:
Check out this branch:
https://github.com/rvilarl/opensheetmusicdisplay/tree/npm-upgrade
Specifically this commit:
rvilarl/opensheetmusicdisplay@df20f00
Run npm install and npm test, which will crash.
The text was updated successfully, but these errors were encountered: