-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cross disk relative paths #433
fix: cross disk relative paths #433
Conversation
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 42.46% 43.55% +1.08%
==========================================
Files 3 3
Lines 219 225 +6
Branches 48 49 +1
==========================================
+ Hits 93 98 +5
- Misses 103 104 +1
Partials 23 23
Continue to review full report at Codecov.
|
Hey, is this something you are still interested in? |
3642b0f
to
6f60c9d
Compare
Yes we are still interested in this. I just rebased on latest master, what else can we do to move this forward? |
He @mvanbutselaar , sorry for the delay. We just released a v5.0.0 release that changed quite a bit since this PR. If you're still interested, would you mind seeing if this is still an issue against the latest release? We no longer use relative paths from what I cant tell so hopefully this is resolved for you 🤞 . If not I can do my best to help you get this resolved in the latest version. Thanks for your contribution, it is much appreciated! |
By the way, paths are still broken for Windows with the current master build: Maybe something like this PR is still needed. (On MacOS, the path issues seem solved with the current master) |
closing due to lack of feedback |
This PR contains a:
Motivation / Use-Case
We use Karma and Webpack, as the base for a testing tool, which can be installed globally. On Windows there is an issue when the tool is installed on one drive (C:), and the codebase being tested is on another drive (F:).
The issue is with relative path resolving on two absolute paths on different roots/drives, which returns an absolute path. This causes the process to get stuck infinitely after compilation, due to not being able to read the output (because the lookup key is not relative).
Breaking Changes
There are no breaking changes.
Additional Info