sys: uartpb: use a unique ID to identify each Protobuf message #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embedded Template Library (ETL) is a drop-in replacement for the C++ standard library with fixed-size containers [1]. ETL package was introduced in RIOT 2022.04 [2]. Add -Wno-cast-align compilation flag to suppress warnings introduced by ETL headers. [1] https://www.etlcpp.com/ [2] RIOT-OS/RIOT#17477 Signed-off-by: Eric Courtois <eric.courtois@gmail.com>
gdoffe
reviewed
Jul 29, 2022
gdoffe
reviewed
Jul 29, 2022
gdoffe
reviewed
Jul 29, 2022
Using a unique id for each Protobuf message allows libraries/applications defining these messages to register a callback function associated with each id. This way, uartpb is not dependent of applications anymore, which had to declare a Protobuf message gathering all known Protobuf messages. This unique id will be sent first, followed by encoded Protobuf message. The unique id can also be sent alone if the message does not required any content (like a reset or trigger message). This commit also updates all modules and applications affected by this refactoring. Fixes #67 Signed-off-by: Eric Courtois <eric.courtois@gmail.com>
ecourtois
force-pushed
the
67-sys-uartpb-use-a-unique-id-to-identify-each-protobuf-message
branch
from
35576c6 to
4bac8d2
Compare
gdoffe
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
LGTM assuming few points on log/error/debug messages !
Good job @ecourtois !
ecourtois
deleted the
67-sys-uartpb-use-a-unique-id-to-identify-each-protobuf-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a unique ID for each Protobuf message allows libraries/applications defining these messages to register a callback function associated with each ID. This way, uartpb is not dependent of applications anymore, which had to declare a Protobuf message gathering all known Protobuf messages.
This unique ID will be sent first, followed by encoded Protobuf message. The unique id can also be sent alone if the message does not required any content (like a reset or trigger message).