Fix possible buffer overflow in ClpSimplexOther
#279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mart-Bogdan
force-pushed
the
orig/stable/1.17
branch
from
4d8b7e5
to
31a8506
Compare
Mart-Bogdan
force-pushed
the
orig/stable/1.17
branch
from
31a8506
to
2e6b5f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found this as warning from GCC when was installing some packages from AUR.
There is possibility of buffer overflow, especially in this case:
Because we are using content of array
lineinside template, and it can be 199 chars already.Actually offending line was already fixed in upstrem (this repo) by using buffer of size 300, but anyway using snprintf is safer.