Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible buffer overflow in ClpSimplexOther #279

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Fix possible buffer overflow in ClpSimplexOther #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions Clp/src/ClpSimplexOther.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2135,7 +2135,7 @@ int ClpSimplexOther::parametrics(double startingTheta, double &endingTheta, doub
}
if (maxTheta < endingTheta) {
char line[100];
sprintf(line, "Crossover considerations reduce ending theta from %g to %g\n",
snprintf(line, sizeof(line), "Crossover considerations reduce ending theta from %g to %g\n",
endingTheta, maxTheta);
handler_->message(CLP_GENERAL, messages_)
<< line << CoinMessageEol;
Expand Down Expand Up @@ -2247,7 +2247,7 @@ int ClpSimplexOther::parametrics(double startingTheta, double &endingTheta, doub
copyModel.dual();
if (copyModel.problemStatus()) {
char line[100];
sprintf(line, "Can not get to theta of %g\n", startingTheta);
snprintf(line, sizeof(line), "Can not get to theta of %g\n", startingTheta);
handler_->message(CLP_GENERAL, messages_)
<< line << CoinMessageEol;
canTryQuick = false; // do slowly to get exact amount
Expand All @@ -2272,7 +2272,7 @@ int ClpSimplexOther::parametrics(double startingTheta, double &endingTheta, doub
}
perturbation_ = savePerturbation;
char line[100];
sprintf(line, "Ending theta %g\n", endingTheta);
snprintf(line, sizeof(line), "Ending theta %g\n", endingTheta);
handler_->message(CLP_GENERAL, messages_)
<< line << CoinMessageEol;
return problemStatus_;
Expand All @@ -2291,8 +2291,8 @@ int ClpSimplexOther::parametrics(const char *dataFile)
return -2;
}

if (!fgets(line, 200, fp)) {
sprintf(line, "Empty parametrics file %s?", dataFile);
if (!fgets(line, sizeof(line), fp)) {
snprintf(line, sizeof(line), "Empty parametrics file %s?", dataFile);
handler_->message(CLP_GENERAL, messages_)
<< line << CoinMessageEol;
fclose(fp);
Expand Down Expand Up @@ -2369,14 +2369,14 @@ int ClpSimplexOther::parametrics(const char *dataFile)
intervalTheta = 0.0;
if (!good) {
char line2[300];
sprintf(line2, "Odd first line %s on file %s?", line, dataFile);
snprintf(line2, sizeof(line2), "Odd first line %s on file %s?", line, dataFile);
handler_->message(CLP_GENERAL, messages_)
<< line2 << CoinMessageEol;
fclose(fp);
return -2;
}
if (!fgets(line, 200, fp)) {
sprintf(line, "Not enough records on parametrics file %s?", dataFile);
if (!fgets(line, sizeof(line), fp)) {
snprintf(line, sizeof(line), "Not enough records on parametrics file %s?", dataFile);
handler_->message(CLP_GENERAL, messages_)
<< line << CoinMessageEol;
fclose(fp);
Expand Down Expand Up @@ -2460,7 +2460,7 @@ int ClpSimplexOther::parametrics(const char *dataFile)
int nLine = 0;
//int nBadLine = 0;
int nBadName = 0;
while (fgets(line, 200, fp)) {
while (fgets(line, sizeof(line), fp)) {
if (!strncmp(line, "ENDATA", 6) || !strncmp(line, "COLUMN", 6))
break;
nLine++;
Expand Down Expand Up @@ -2537,11 +2537,11 @@ int ClpSimplexOther::parametrics(const char *dataFile)
strcpy(saveLine, line);
}
}
sprintf(line, "%d Row fields and %d records", nAcross, nLine);
snprintf(line, sizeof(line), "%d Row fields and %d records", nAcross, nLine);
handler_->message(CLP_GENERAL, messages_)
<< line << CoinMessageEol;
if (nBadName) {
sprintf(line, " ** %d records did not match on name/sequence, first bad %s", nBadName, saveLine);
snprintf(line, sizeof(line), " ** %d records did not match on name/sequence, first bad %s", nBadName, saveLine);
handler_->message(CLP_GENERAL, messages_)
<< line << CoinMessageEol;
returnCode = -1;
Expand All @@ -2552,16 +2552,16 @@ int ClpSimplexOther::parametrics(const char *dataFile)
}
delete[] rowNames;
} else {
sprintf(line, "Duplicate or unknown keyword - or name/number fields wrong");
snprintf(line, sizeof(line), "Duplicate or unknown keyword - or name/number fields wrong");
handler_->message(CLP_GENERAL, messages_)
<< line << CoinMessageEol;
returnCode = -1;
good = false;
}
}
if (good && (!strncmp(line, "COLUMN", 6) || !strncmp(line, "column", 6))) {
if (!fgets(line, 200, fp)) {
sprintf(line, "Not enough records on parametrics file %s after COLUMNS?", dataFile);
if (!fgets(line, sizeof(line), fp)) {
snprintf(line, sizeof(line), "Not enough records on parametrics file %s after COLUMNS?", dataFile);
handler_->message(CLP_GENERAL, messages_)
<< line << CoinMessageEol;
fclose(fp);
Expand Down Expand Up @@ -2632,7 +2632,7 @@ int ClpSimplexOther::parametrics(const char *dataFile)
int nLine = 0;
//int nBadLine = 0;
int nBadName = 0;
while (fgets(line, 200, fp)) {
while (fgets(line, sizeof(line), fp)) {
if (!strncmp(line, "ENDATA", 6))
break;
nLine++;
Expand Down Expand Up @@ -2711,11 +2711,11 @@ int ClpSimplexOther::parametrics(const char *dataFile)
strcpy(saveLine, line);
}
}
sprintf(line, "%d Column fields and %d records", nAcross, nLine);
snprintf(line, sizeof(line), "%d Column fields and %d records", nAcross, nLine);
handler_->message(CLP_GENERAL, messages_)
<< line << CoinMessageEol;
if (nBadName) {
sprintf(line, " ** %d records did not match on name/sequence, first bad %s", nBadName, saveLine);
snprintf(line, sizeof(line), " ** %d records did not match on name/sequence, first bad %s", nBadName, saveLine);
handler_->message(CLP_GENERAL, messages_)
<< line << CoinMessageEol;
returnCode = -1;
Expand All @@ -2726,7 +2726,7 @@ int ClpSimplexOther::parametrics(const char *dataFile)
}
delete[] columnNames;
} else {
sprintf(line, "Duplicate or unknown keyword - or name/number fields wrong");
snprintf(line, sizeof(line), "Duplicate or unknown keyword - or name/number fields wrong");
handler_->message(CLP_GENERAL, messages_)
<< line << CoinMessageEol;
returnCode = -1;
Expand Down Expand Up @@ -3282,7 +3282,7 @@ int ClpSimplexOther::parametrics(double startingTheta, double &endingTheta,
delete rowArray_[5];
rowArray_[5] = NULL;
char line[100];
sprintf(line, "Ending theta %g\n", endingTheta);
snprintf(line, sizeof(line), "Ending theta %g\n", endingTheta);
handler_->message(CLP_GENERAL, messages_)
<< line << CoinMessageEol;
return problemStatus_;
Expand Down Expand Up @@ -5932,7 +5932,7 @@ ClpSimplexOther::gubVersion(int *whichRows, int *whichColumns,
}
}
if (!numberNormal) {
sprintf(message, "Putting back one gub row to make non-empty");
snprintf(message, sizeof(message), "Putting back one gub row to make non-empty");
handler_->message(CLP_GENERAL2, messages_)
<< message << CoinMessageEol;
rowIsGub[smallestGubRow] = -1;
Expand Down Expand Up @@ -6146,7 +6146,7 @@ ClpSimplexOther::gubVersion(int *whichRows, int *whichColumns,
}
}
}
sprintf(message, "** Before adding matrix there are %d rows and %d columns",
snprintf(message, sizeof(message), "** Before adding matrix there are %d rows and %d columns",
model2->numberRows(), model2->numberColumns());
handler_->message(CLP_GENERAL2, messages_)
<< message << CoinMessageEol;
Expand Down