fix: line chart wont interpolate on data changes #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: useAnimatedReaction previous value being null
cam-shaw
suggested changes
Jul 26, 2023
|
Hey @Amurmurmur , Just curious, how is this tested on web ? I think we should ensure that we support both edit : I've tested the current version v2.3.0 on metro on web, expo 49, and reanimated v3.4.0 and the linear chart is working clean, no flicker, no issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to Expo v49 and react-native-reanimated v3 the chart will not interpolate on data switch due to
previousvalue always being returned as null.The same code works fine with Reanimated v2 and expo v48, most likely a buggy on the reanimated side (issue raised with them no feedback yet)
As of now this PR fixes it to support Reanimated v3 and Expo v49.