Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiles should add extra descriptive class #189

Closed
polyester opened this issue Apr 28, 2013 · 4 comments
Closed

tiles should add extra descriptive class #189

polyester opened this issue Apr 28, 2013 · 4 comments
Milestone

Comments

@polyester
Copy link
Member

it would be helpful if tiles add an extra class on what kind of tile they are. Something like 'class="covertile-pfg"', 'class="covertile-list"', to make it easier for CSS and diazo to grip onto. I'm suggesting covertile here as name, because there might be future confusion when others start using the name 'tiles' as well

@agnogueira
Copy link
Contributor

+1

@hvelarde
Copy link
Member

I think this is related with #190 that is already closed.

should we consider this as implemented?

@agnogueira
Copy link
Contributor

No, it's different. This is an automatic class for each tile, always on code, not defined by the user

@polyester
Copy link
Member Author

the use-case is different. Both are good, but this allows styling of all 'list' type tiles, without end user intervention

warpr added a commit to warpr/collective.cover that referenced this issue Oct 25, 2013
This addresses the issue collective#189 for all the default tiles, but doesn't do it automatically for new tiles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants