Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Port Color modification tests to the new test format #395

Closed
Tracked by #399
lloydk opened this issue Feb 3, 2024 · 2 comments · Fixed by #480
Closed
Tracked by #399

[chore] Port Color modification tests to the new test format #395

lloydk opened this issue Feb 3, 2024 · 2 comments · Fixed by #480
Labels
help wanted Extra attention is needed Topic: testing

Comments

@lloydk
Copy link
Collaborator

lloydk commented Feb 3, 2024

No description provided.

@lloydk lloydk changed the title Port missing Color modification tests Port Color modification tests to the new test format Feb 3, 2024
@LeaVerou
Copy link
Member

LeaVerou commented Feb 4, 2024

Hi @lloydk, it would be helpful to link to the part of the testsuite you're referring to. E.g. I thought these had already been ported? See https://github.com/color-js/color.js/blob/main/test/conversions.js

@lloydk
Copy link
Collaborator Author

lloydk commented Feb 4, 2024

Hi @lloydk, it would be helpful to link to the part of the testsuite you're referring to. E.g. I thought these had already been ported? See https://github.com/color-js/color.js/blob/main/test/conversions.js

These tests:

https://github.com/color-js/color.js/blob/main/tests/modifications.html

@LeaVerou LeaVerou changed the title Port Color modification tests to the new test format [chore] Port Color modification tests to the new test format Feb 4, 2024
@LeaVerou LeaVerou added the help wanted Extra attention is needed label Feb 4, 2024
@LeaVerou LeaVerou mentioned this issue Feb 4, 2024
Open
6 tasks
lloydk added a commit to lloydk/color.js that referenced this issue Mar 12, 2024
@lloydk
Port color modification tests
96e1357 
Closes color-js#395
@lloydk lloydk mentioned this issue Mar 12, 2024
Merged
lloydk added a commit that referenced this issue Mar 12, 2024
@lloydk
Port color modification tests (#480)
e29ecae 
* Port color modification tests

Closes #395

* Use run instead of args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed Topic: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Port color modification tests lloydk/color.js
2 participants
@lloydk @LeaVerou