Port color modification tests #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LeaVerou
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Thanks so much for working on this, you rock!
My only comment is that you don’t actually need run there at all, you just need to rename args to run and it should do what you intend here (and if it doesn't that's a bug to fix).
There is probably a way to make these a bit less repetitive, but whatevs, I'm just very glad to have them ported! 😄
Thanks again!
test/modifications.js
Outdated
| name: "Color modification tests", | ||
| description: "These tests modify one or more coordinates and check the result.", | ||
| run (func) { | ||
| return func(); |
There was a problem hiding this comment.
That is never needed, you can just have a run on each individual test. :)
There was a problem hiding this comment.
Fixed, that's way better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #395