Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[types] Generate declarations from JS #564

Merged
merged 9 commits into from
Jun 27, 2024
Merged

[types] Generate declarations from JS #564

merged 9 commits into from
Jun 27, 2024

Conversation

MysteryBlokHed
Copy link
Member

Closes #563

Builds declaration files automatically instead of letting editors use JSDoc.

Currently, source maps are also enabled, since it lets developers see exactly where the types for a given file actually come from.

@netlify Netlify
Copy link

netlify bot commented Jun 24, 2024 •
edited
Loading

❌ Deploy Preview for colorjs failed. Why did it fail? →

Name Link
🔨 Latest commit 369b075
🔍 Latest deploy log https://app.netlify.com/sites/colorjs/deploys/667cb4daf7c5030008227ce0

lloydk
lloydk reviewed Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@lloydk lloydk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have some compilation errors in my project but I think we're getting closer.

package.json Outdated Show resolved Hide resolved
scripts/copy-declarations.js Outdated Show resolved Hide resolved
MysteryBlokHed and others added 2 commits June 26, 2024 13:07
@MysteryBlokHed @lloydk
fix: Ordering in build:ts script
c4d4517 
Co-authored-by: Lloyd Kupchanko <lloyd@lloydk.ca>
@MysteryBlokHed @lloydk
fix: Create declarations directory if nonexistant
c94bf93 
Co-authored-by: Lloyd Kupchanko <lloyd@lloydk.ca>
@lloydk lloydk self-requested a review June 26, 2024 21:32
lloydk
lloydk approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@lloydk lloydk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MysteryBlokHed MysteryBlokHed merged commit 2821bc4 into main Jun 27, 2024
0 of 5 checks passed
@MysteryBlokHed MysteryBlokHed deleted the types/generate-declarations branch June 27, 2024 01:01
@jgerigmeyer jgerigmeyer mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lloydk lloydk lloydk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[types] Generate declarations from JS
2 participants
@MysteryBlokHed @lloydk