-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[types] Remove module augmentation (v0.6) #567
Conversation
This is essentially the same change as #566, but for the main branch instead of a patch for v0.5.
❌ Deploy Preview for colorjs failed. Why did it fail? →
|
LGTM I tested it with #569 and all the type tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think build:ts is being run. On my phone with no reading glasses so
I could be wrong. If that isn’t it then I’ll take a look when I get home.
…On Thu, Jun 27, 2024 at 9:45 AM Jonny Gerig Meyer ***@***.***> wrote:
***@***.**** commented on this pull request.
These specific changes look good, but it looks like since #564
<#564> was merged, the entire
build process is failing because of errors in the tsc step. Even
combining this with #569 <#569>
doesn't help, so it's difficult for me to test. What am I missing?
—
Reply to this email directly, view it on GitHub
<#567 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAP4MCQLL75RE6AIUW3LYDZJQXQBAVCNFSM6AAAAABJ65FWNSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBVG44TKOJQGE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
I created #571 that should allow the build to run. |
I'll try merging this and the other active typing PR's and see what the situation is like then |
This is essentially the same change as #566, but for the main branch instead of a patch for v0.5.
I don't think there should be anything missing here—I re-copied and pasted the augmentation contents from
index.d.ts
tocolor.d.ts
to make sure I didn't miss any new properties—but review has been requested just in case :)