-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added --import command-line option #1526
Conversation
pros: reuse MillIvyHook cons: we load each plugin separately
@lihaoyi I'm asking for a review or comment here. I'm myself a bit undecided. I think the |
@lefou I think it looks reasonable to me; I don't have a use for it, but I imagine others might. Maybe call it |
@lihaoyi Thank you! I like Potential users are @scala-steward and Metals, which want to run mill with additional external modules. |
With this PR applied, you can run targets from external modules from the command-line without touching the `build.sc`. Example: ``` dev-mill --plugin ivy:de.tototec::de.tobiasroeser.mill.vcs.version_mill0.10.0-M2:0.1.2 show de.tobiasroeser.mill.vcs.version.VcsVersion/vcsState ``` This PR also add support for empty versions in $ivy-imports, which will get expanded to the exact mill version. This makes consuming mill contrib plugins even more easy. Example: Generating Bloop Config without modifying the `build.sc` ``` mill --plugin ivy:com.lihaoyi::mill-contrib-bloop: mill.contrib.bloop.Bloop/install ``` See pull request: com-lihaoyi#1526
With this PR applied, you can run targets from external modules from the command-line without touching the `build.sc`. Example: ``` dev-mill --plugin ivy:de.tototec::de.tobiasroeser.mill.vcs.version_mill0.10.0-M2:0.1.2 show de.tobiasroeser.mill.vcs.version.VcsVersion/vcsState ``` This PR also add support for empty versions in $ivy-imports, which will get expanded to the exact mill version. This makes consuming mill contrib plugins even more easy. Example: Generating Bloop Config without modifying the `build.sc` ``` mill --plugin ivy:com.lihaoyi::mill-contrib-bloop: mill.contrib.bloop.Bloop/install ``` See pull request: #1526 Pull request: #1562
Motivation: Some plugins provide "External Modules" which can be used by mill without modifying the
build.sc
.With this PR applied, you can run targets from external modules from the command-line without touching the
build.sc
.Example:
This PR also add support for empty versions in $ivy-imports, which will get expanded to the exact mill version. This makes consuming mill contrib plugins even more easy.
Example: Generating Bloop Config without modyfing the
build.sc