Backported support for more mill-specifics in $ivy-import #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support $MILL_BIN_PLATFORM placeholder and new $ivy.`g::a::v` syntax (borrowed from Scala JS/Native dependency notation) Also updated Documentation and renamed two pages (Modules => Plugins). See pull request: com-lihaoyi#1485
lolgab
reviewed
Nov 11, 2021
|
|
||
| .Example: Use `mill-contrib-bloop` plugin matching the current Mill version | ||
| ---- | ||
| import $ivy:`com.lihaoyi:mill-contrib-bloop:$MILL_VERSION` |
There was a problem hiding this comment.
Shouldn't this be:
Suggested change
| import $ivy:`com.lihaoyi:mill-contrib-bloop:$MILL_VERSION` | |
| import $ivy.`com.lihaoyi:mill-contrib-bloop:$MILL_VERSION` |
?
There was a problem hiding this comment.
You're absolutely right. I plan to also pack-port PR #1526 and therefore will keep this as-is to avoid clashes.
|
|
||
| .Example: Using `mill-vcs-version` plugin matching the current Mill Binary Platfrom | ||
| ---- | ||
| import $ivy:`de.tototec::de.tobiasroeser.mill.vcs.version::0.1.2` |
There was a problem hiding this comment.
Also here:
Suggested change
| import $ivy:`de.tototec::de.tobiasroeser.mill.vcs.version::0.1.2` | |
| import $ivy.`de.tototec::de.tobiasroeser.mill.vcs.version::0.1.2` |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support $MILL_BIN_PLATFORM placeholder and new $ivy.
g::a::vsyntax (borrowed from Scala JS/Native dependency notation)Also updated Documentation and renamed two pages (Modules => Plugins).
See pull request: #1485