Don't add semanticdb plugin for Scala 3. #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckipp01
commented
Nov 29, 2021
ckipp01
commented
Nov 29, 2021
ckipp01
force-pushed
the
scala3Metals
branch
3 times, most recently
from
bbc4ae7
to
1f44ee0
Compare
lefou
reviewed
Dec 1, 2021
lefou
reviewed
Dec 1, 2021
For Scala 3 semanticdb is produced natively by the compiler behind the `-Xsemanticdb` flag, so the plugin isn't necessary. This change ensures the correct scalacOptions are set when using Scala 3 with ScalaMetalsSupport.
|
Thank you! |
pbuszka
pushed a commit
to pbuszka/mill
that referenced
this pull request
Dec 26, 2021
For Scala 3 semanticdb is produced natively by the compiler behind the `-Xsemanticdb` flag, so the plugin isn't necessary. This change ensures the correct scalacOptions are set when using Scala 3 with ScalaMetalsSupport. Pull request: com-lihaoyi#1593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Scala 3 semanticdb is produced natively by the compiler behind the
-Xsemanticdbflag, so the plugin isn't necessary. This change ensuresthe correct scalacOptions are set when using Scala 3 with
ScalaMetalsSupport.