Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add semanticdb plugin for Scala 3. #1593

Merged
merged 1 commit into from
Dec 1, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 29 additions & 6 deletions scalalib/src/mill/scalalib/bsp/ScalaMetalsSupport.scala
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,46 @@ package mill.scalalib.bsp
import mill.api.experimental
import mill.{Agg, T}
import mill.define.Target
import mill.scalalib.api.ZincWorkerUtil.isScala3
import mill.scalalib.{Dep, DepSyntax, ScalaModule}
import mill.api.Result

/*+ Enable some common settings required to properly support Metals Language Server (via BSP). */
@experimental
trait ScalaMetalsSupport extends ScalaModule {

/** The semanticDB version to use. It needs to support your configured Scala versions. */
def semanticDbVersion: T[String]
/** The semanticDB version to use. It needs to support your configured Scala 2 version. */
def semanticDbVersion: T[String] = T { "" }

override def scalacPluginIvyDeps: Target[Agg[Dep]] = T {
super.scalacPluginIvyDeps() ++ Agg(
ivy"org.scalameta:::semanticdb-scalac:${semanticDbVersion()}"
)
if (!isScala3(scalaVersion()) && semanticDbVersion().isEmpty) {
val msg =
"""|
|When using ScalaMetalsSupport with Scala 2 you must provide a semanticDbVersion
|
|def semanticDbVersion = ???
|""".stripMargin
Result.Failure(msg)
} else if (isScala3(scalaVersion())) {
Result.Success(super.scalacPluginIvyDeps())
} else {
Result.Success(
super.scalacPluginIvyDeps() ++ Agg(
ivy"org.scalameta:::semanticdb-scalac:${semanticDbVersion()}"
)
)
}
}

/** Adds some options and configures the semanticDB plugin. */
override def mandatoryScalacOptions: Target[Seq[String]] = T {
super.mandatoryScalacOptions() ++ Seq("-Yrangepos", s"-P:semanticdb:sourceroot:${T.workspace}")
super.mandatoryScalacOptions() ++ {
if (isScala3(scalaVersion())) {
Seq("-Xsemanticdb")
ckipp01 marked this conversation as resolved.
Show resolved Hide resolved
} else {
Seq("-Yrangepos", s"-P:semanticdb:sourceroot:${T.workspace}")
}
}
}

/** Filters options unsupported by Metals. */
Expand Down