-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dynamic choice of HTTP method #94
Conversation
@lihaoyi By looking at other tests: diff --git a/requests/test/src/requests/RequestTests.scala b/requests/test/src/requests/RequestTests.scala
index 834eea5..72dd505 100644
--- a/requests/test/src/requests/RequestTests.scala
+++ b/requests/test/src/requests/RequestTests.scala
@@ -82,9 +82,9 @@ object RequestTests extends TestSuite{
val res1 = requests.send("put")(
"https://httpbin.org/put",
- data = Map("hello" -> "world", "foo" -> "baz"),
+ data = new RequestBlob.FormEncodedRequestBlob(Map("hello" -> "world", "foo" -> "baz")),
chunkedUpload = true
- ).text
+ ).text()
assert(read(res1).obj("form") == Obj("foo" -> "baz", "hello" -> "world"))
}
Maybe it's some limitation that can be removed, but not in this PR for sure. |
@lolgab afaict it's a bug in the scala3 compiler, so I'm fine skipping that test in scala3 for now. The chance of us causing scala3-specific bugs is rather low, and if the bug is on the scala3 side it's their responsibility to fix rather than ours |
the def text: String and if declared like: def text(): String as it happens here. About My 2 cents: |
|
@lihaoyi Yeah, I get your point! |
I moved all tests involving that implicit conversion to the |
Fixes #67
Fixes #52
This was always possible in a roundabout way via
But this PR adds a convenient alias and documents it for discoverability