Disable body reading on head requests #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
force-pushed
the
head-no-body
branch
from
3156364
to
9794e6f
Compare
lolgab
requested changes
Dec 10, 2021
| // The HEAD method is identical to GET except that the server | ||
| // MUST NOT return a message-body in the response. | ||
| // https://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html section 9.4 | ||
| if (verb.toLowerCase == "head") f(new ByteArrayInputStream(Array())) |
There was a problem hiding this comment.
The HTTP verbs are case-sensitive. Probably you need to check for HEAD because head or Head are considered extension-methods and don't share the HEAD semantics.
Suggested change
| if (verb.toLowerCase == "head") f(new ByteArrayInputStream(Array())) | |
| if (verb == "HEAD") f(new ByteArrayInputStream(Array())) |
There was a problem hiding this comment.
@lolgab updated as per your suggestion
lolgab
approved these changes
Dec 10, 2021
|
Just out of curiosity, why you needed to introduce the |
|
@lihaoyi Oh, now it makes much more sense! |
|
@lolgab yeah waiting for your review on that one |
lolgab
reviewed
Dec 10, 2021
| @@ -1,11 +1,11 @@ | |||
| package requests | |||
|
|
|||
| import requests.Requester.methodField | |||
lolgab
approved these changes
Dec 10, 2021
lolgab
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37
Review by @lolgab