Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CVE from bbolt #148

Merged
merged 5 commits into from
Apr 7, 2024
Merged

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Apr 4, 2024

For bolt, the upstream is alive again, so I guess we keep it, even if its reason to live is just benchmarking.

@faddat faddat requested a review from a team as a code owner April 4, 2024 17:30
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (fb4f703) to head (1297537).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   76.80%   78.12%   +1.31%     
==========================================
  Files          23       23              
  Lines        2048     1714     -334     
==========================================
- Hits         1573     1339     -234     
+ Misses        403      298     -105     
- Partials       72       77       +5     

see 22 files with indirect coverage changes

see 22 files with indirect coverage changes

@faddat faddat mentioned this pull request Apr 5, 2024
@cason
Copy link
Contributor

cason commented Apr 5, 2024

This encompasses increasing Go version number, please add it to the description.

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @faddat ❤️

@melekes melekes enabled auto-merge April 7, 2024 06:01
@melekes melekes added this pull request to the merge queue Apr 7, 2024
Merged via the queue into cometbft:main with commit ba19f7b Apr 7, 2024
7 of 8 checks passed
@adizere adizere added this to the 2024-Q2 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants