Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sqlite #149

Closed
wants to merge 11 commits into from
Closed

feat: sqlite #149

wants to merge 11 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Apr 4, 2024

This is built from:

... so please merge #148 first.

This PR allows Comet to use sqlite as the db backend.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.12%. Comparing base (fb4f703) to head (7febd20).
Report is 24 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   76.80%   78.12%   +1.31%     
==========================================
  Files          23       23              
  Lines        2048     1714     -334     
==========================================
- Hits         1573     1339     -234     
+ Misses        403      298     -105     
- Partials       72       77       +5     
Files Coverage Δ
db.go 41.17% <ø> (+6.17%) ⬆️
boltdb.go 63.10% <0.00%> (+5.84%) ⬆️

... and 20 files with indirect coverage changes

Files Coverage Δ
db.go 41.17% <ø> (+6.17%) ⬆️
boltdb.go 63.10% <0.00%> (+5.84%) ⬆️

... and 20 files with indirect coverage changes

@faddat
Copy link
Contributor Author

faddat commented Apr 5, 2024

whoa!

I did not realize this is working lolz -- thanks for the patch @assafmo !

Let's do this thing!

@faddat faddat marked this pull request as ready for review April 5, 2024 10:04
@faddat faddat requested a review from a team as a code owner April 5, 2024 10:04
@faddat faddat marked this pull request as draft April 5, 2024 10:07
@melekes
Copy link
Contributor

melekes commented Apr 7, 2024

Interesting to see SQLite here 👍

@faddat
Copy link
Contributor Author

faddat commented Apr 8, 2024

I thought so too!

Gotta credit @assafmo for the idea, he asked if we had support and I thought... hm, why not!

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Apr 19, 2024
@assafmo
Copy link

assafmo commented Apr 19, 2024

Bump

@github-actions github-actions bot removed the Stale label Apr 20, 2024
@adizere adizere added this to the 2024-Q2 milestone Apr 24, 2024
@adizere
Copy link
Member

adizere commented Apr 24, 2024

We can ship this in the next release, most likely in May.

Copy link

github-actions bot commented May 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label May 5, 2024
@assafmo
Copy link

assafmo commented May 5, 2024

.

@github-actions github-actions bot removed the Stale label May 6, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label May 17, 2024
@assafmo
Copy link

assafmo commented May 17, 2024

.

@github-actions github-actions bot removed the Stale label May 18, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label May 28, 2024
@assafmo
Copy link

assafmo commented May 28, 2024

Hate this stale bot

@github-actions github-actions bot removed the Stale label May 29, 2024
Copy link

github-actions bot commented Jun 8, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Jun 8, 2024
@assafmo
Copy link

assafmo commented Jun 8, 2024

.

@github-actions github-actions bot removed the Stale label Jun 9, 2024
@melekes
Copy link
Contributor

melekes commented Jun 10, 2024

I'm going to close this as this is stale. @faddat @assafmo please let us know if/when you have time to finish this work.

@melekes melekes closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants