-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sqlite #149
feat: sqlite #149
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 76.80% 78.12% +1.31%
==========================================
Files 23 23
Lines 2048 1714 -334
==========================================
- Hits 1573 1339 -234
+ Misses 403 298 -105
- Partials 72 77 +5
... and 20 files with indirect coverage changes
|
SQLite: Fix Get() to return nil when there is no value
whoa! I did not realize this is working lolz -- thanks for the patch @assafmo ! Let's do this thing! |
Interesting to see SQLite here 👍 |
I thought so too! Gotta credit @assafmo for the idea, he asked if we had support and I thought... hm, why not! |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Bump |
We can ship this in the next release, most likely in May. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hate this stale bot |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
. |
This is built from:
... so please merge #148 first.
This PR allows Comet to use sqlite as the db backend.