Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next set of integration test improvements #4699

Closed
snoyberg opened this issue Apr 5, 2019 · 0 comments
Closed

Next set of integration test improvements #4699

snoyberg opened this issue Apr 5, 2019 · 0 comments
Assignees
@snoyberg
Milestone
P1: Must

Comments

@snoyberg
Copy link
Contributor

snoyberg commented Apr 5, 2019

Once #4698 is merged, I believe we'll only have two remaining test failures. Both of those are due to the fact that stack script is ignoring the global system-ghc: true setting. Both of those should be addressed by #3887, which I'll hit soon I hope.

The other minor improvement I want to make is to respect a PANTRY_CONFIG environment variable, which overrides the default of $STACK_ROOT/pantry. This would allow the cleanup code in IntegrationSpec to be much nicer.
@snoyberg snoyberg added this to the P1: Must milestone Apr 5, 2019
@snoyberg snoyberg self-assigned this Apr 5, 2019
snoyberg added a commit that referenced this issue Apr 5, 2019
@snoyberg
Respect PANTRY_ROOT #4699
35de71b 
And use it in the integration test suite
snoyberg added a commit that referenced this issue Apr 5, 2019
@snoyberg
Rename NoConfig to NoProject
98bb45d 
This also changes the behavior: we _do_ load up the user config file,
just no project config file.

* Fixes #3705
* Fixes #3887
* Fixes #4699
@snoyberg snoyberg mentioned this issue Apr 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snoyberg snoyberg

Labels
None yet
Projects
None yet
Milestone
P1: Must
Development

No branches or pull requests
1 participant
@snoyberg