Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] exclude files that aren't generated from being included in modules #59

Closed
mattlewis92 opened this issue Jan 8, 2017 · 3 comments

Comments

@mattlewis92
Copy link
Contributor

Overview of the issue

Currently if you exclude internal services / components etc for your lib, they still get referenced by the NgModule but no docs are generated for them.

Suggest a Fix

The list of files that will be generated is available from the beginning of the run, so the module generation code should just look up each dependency in this array first and exclude them if not included.

@vogloblinsky
Copy link
Contributor

Did you have a use-case for clarification ?

@mattlewis92
Copy link
Contributor Author

Sure thing, so on my calendar I have a load of internal components that the main externally usable ones are made up from: https://github.com/mattlewis92/angular-calendar

I exclude them via tsconfig so no docs get generated for them, but the parent NgModule still links to them.

Happy to work on a PR for this as well once I have some free time 😄

mattlewis92 pushed a commit to mattlewis92/compodoc that referenced this issue Jan 19, 2017
@lock
Copy link

lock bot commented Oct 1, 2019

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem. Why locking ? Having issues with the most up-to-date context.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants