Adds nested object support #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bjects Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
this ensures that parsing will not manipulate the Object prototype or override prototypes on the returned object Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
|
you should be able to use https://github.com/visionmedia/node-querystring for nested object support. this module should remain as simple as possible. |
|
node-querystring defines its own shims, which is reasonable for its distribution model, but is not ideal for a component. |
|
oh you can open PRs to refactor that. not down to merge this though since there are security issues with that module and i don't want to duplicate efforts or merge in code. |
|
going to close this. if you want to maintain a slimmer version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds efficient and safe nested object and array support.
Tests are present around prototypal redefinition safety and other such maliciousness.