Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] Incorrect Failed label on PRs #15130

Closed
ericLemanissier opened this issue Jan 6, 2023 · 4 comments
Closed

[service] Incorrect Failed label on PRs #15130

ericLemanissier opened this issue Jan 6, 2023 · 4 comments
Assignees

Comments

@ericLemanissier
Copy link
Contributor

ericLemanissier commented Jan 6, 2023

What is your problem/feature request?

A "lot" of pull requests currently in flight have a Failed label, even if all CI finished successfully. I'm listing them below in order to show the magnitude of the problem, and to encourage reviewers to go review these ones too (because the bot seems to merge PRs that are approved, even if they have the Failed label):

@SpaceIm
Copy link
Contributor

SpaceIm commented Jan 6, 2023

@jwillikers
Copy link
Contributor

@ericLemanissier Thanks for opening this issue. I think this is effecting what shows up for review at https://prince-chrismc.github.io/conan-center-index-pending-review/

@prince-chrismc
Copy link
Contributor

It is

@prince-chrismc
Copy link
Contributor

I've manually gone back and fixed as many as I good. Feel free to reopen if I missed anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants