-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for vtu11/1.2.0 #14803
Add recipe for vtu11/1.2.0 #14803
Conversation
Vtu11 is a small C++ header-only library to write unstructured grids using the vtu file format. It keeps the mess of dealing with file writing in different formats away from you. Currently it does not add any features for setting up the required data structure because this vastly differs based on the context in which vtu11 is used. See https://github.com/phmkopp/vtu11 Fixes issue: phmkopp/vtu11#46
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit 6ce965e.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Visual Studio doesn't know this type
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This version should fix the compilation for the msvc
This comment has been minimized.
This comment has been minimized.
@uilianries all checks have passed how to remove the failed label and mark it ready for review? |
There are none to be applied
This comment has been minimized.
This comment has been minimized.
Actually it's a bad UX already mapped to be fixed (internal GH issue). There are 2 pipelines, Conan V1 and V2. The V1 is mandatory, but V2 is only informative. However, if any of them fail, GH will mark that Fail label. So if your PR passed by V1, it's good enough and that label is only realrdd to V2, which is informative only and does not block your PR. BTW, Have a Happy New Year 🍾 |
@uilianries You also the best wishes and thanks for explaining |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my delay, big time on vacations. Only a small consideration related to the c++ exported flag, but in summarize it looks pretty decent!
don't worry @uilianries , the benefits of having access to a JFrog Artifactory Enterprise server is that I can cont. without delay from third parties, and I know how busy you guys are. I do hope you had a great, well-deserved holiday, btw. Anyhow, this is for my personal weekend project Ultimaker/CuraEngine#1806 although my WIP PR is already being used to debug some complex issues. I will update this PR sometime this weekend. |
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bunch of comments... these are fun ones which change downstream based on cppstd
If you need help finishing this let me know :)
Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>
Removing the filesystem.hpp failed when compiling on some Windows systems MSVC needs this to actually report the right value when using the __cplusplus pre-definition macro. See here for details: https://learn.microsoft.com/en-us/cpp/build/reference/zc-cplusplus
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 14 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 15 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
if valid_min_cppstd(self, 17): | ||
apply_conandata_patches(self) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this logic is wrong, specially when package id is cleared...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're correct, good catch. I'm a bit uncertain what the best way is to resolve this. What is your opinion? Should I solve this with a "custom" clear functionality in the package id, clearing everything except settings, compiler version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that the patch should be robust to any C++ standard in the first place.
Vtu11 is a small C++ header-only library to write
unstructured grids using the vtu file format. It
keeps the mess of dealing with file writing in
different formats away from you. Currently it does not add any features for setting up the required
data structure because this vastly differs based on the context in which vtu11 is used.
See https://github.com/phmkopp/vtu11
Fixes phmkopp/vtu11#46
Fixes #14802
Specify library name and version: lib/1.0