Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for vtu11/1.2.0 #14803

Merged
merged 19 commits into from
Apr 12, 2023
Merged

Add recipe for vtu11/1.2.0 #14803

merged 19 commits into from
Apr 12, 2023

Conversation

jellespijker
Copy link
Contributor

Vtu11 is a small C++ header-only library to write
unstructured grids using the vtu file format. It
keeps the mess of dealing with file writing in
different formats away from you. Currently it does not add any features for setting up the required
data structure because this vastly differs based on the context in which vtu11 is used.

See https://github.com/phmkopp/vtu11

Fixes phmkopp/vtu11#46
Fixes #14802

Specify library name and version: lib/1.0

Vtu11 is a small C++ header-only library to write
unstructured grids using the vtu file format. It
keeps the mess of dealing with file writing in
different formats away from you. Currently it does
not add any features for setting up the required
data structure because this vastly differs based on
the context in which vtu11 is used.

See https://github.com/phmkopp/vtu11

Fixes issue: phmkopp/vtu11#46
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Visual Studio doesn't know this type
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

This version should fix the compilation for the msvc
@conan-center-bot

This comment has been minimized.

@jellespijker
Copy link
Contributor Author

@uilianries all checks have passed how to remove the failed label and mark it ready for review?

@jellespijker jellespijker changed the title Add recipe for vtu11/1.1.0 Add recipe for vtu11/1.2.0 Dec 31, 2022
@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

@uilianries all checks have passed how to remove the failed label and mark it ready for review?

Actually it's a bad UX already mapped to be fixed (internal GH issue). There are 2 pipelines, Conan V1 and V2. The V1 is mandatory, but V2 is only informative. However, if any of them fail, GH will mark that Fail label. So if your PR passed by V1, it's good enough and that label is only realrdd to V2, which is informative only and does not block your PR.

BTW, Have a Happy New Year 🍾

@jellespijker
Copy link
Contributor Author

@uilianries You also the best wishes and thanks for explaining

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my delay, big time on vacations. Only a small consideration related to the c++ exported flag, but in summarize it looks pretty decent!

recipes/vtu11/all/conanfile.py Outdated Show resolved Hide resolved
recipes/vtu11/all/test_package/CMakeLists.txt Show resolved Hide resolved
@jellespijker
Copy link
Contributor Author

jellespijker commented Jan 24, 2023

don't worry @uilianries , the benefits of having access to a JFrog Artifactory Enterprise server is that I can cont. without delay from third parties, and I know how busy you guys are. I do hope you had a great, well-deserved holiday, btw.

Anyhow, this is for my personal weekend project Ultimaker/CuraEngine#1806 although my WIP PR is already being used to debug some complex issues.

I will update this PR sometime this weekend.

Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of comments... these are fun ones which change downstream based on cppstd

If you need help finishing this let me know :)

recipes/vtu11/all/conandata.yml Outdated Show resolved Hide resolved
recipes/vtu11/all/conanfile.py Outdated Show resolved Hide resolved
recipes/vtu11/all/conanfile.py Show resolved Hide resolved
recipes/vtu11/all/conanfile.py Outdated Show resolved Hide resolved
recipes/vtu11/all/conanfile.py Outdated Show resolved Hide resolved
recipes/vtu11/all/test_package/CMakeLists.txt Show resolved Hide resolved
recipes/vtu11/config.yml Outdated Show resolved Hide resolved
jellespijker and others added 3 commits April 5, 2023 07:40
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Removing the filesystem.hpp failed when compiling on some Windows systems
MSVC needs this to actually report the right value when using the __cplusplus pre-definition macro.
See here for details: https://learn.microsoft.com/en-us/cpp/build/reference/zc-cplusplus
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 14 (35f05557a6efd8425312c4a36fa4c8020444079f):

  • vtu11/1.2@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 15 (35f05557a6efd8425312c4a36fa4c8020444079f):

  • vtu11/1.2@:
    CI failed to create some packages (All logs)

    Logs for packageID da39a3ee5e6b4b0d3255bfef95601890afd80709:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.cppstd=14
    compiler.runtime=static
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    
    [...]
    -- Using Conan toolchain: C:/J/w/prod-v2/BuildSingleReference/cci-18d23eda/recipes/vtu11/all/test_package/build/msvc-192-x86_64-14-release/generators/conan_toolchain.cmake
    -- Conan toolchain: C++ Standard 14 with extensions OFF
    -- The CXX compiler identification is MSVC 19.29.30148.0
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Conan: Target declared 'vtu11::vtu11'
    -- Conan: Target declared 'ZLIB::ZLIB'
    -- Configuring done
    -- Generating done
    -- Build files have been written to: C:/J/w/prod-v2/BuildSingleReference/cci-18d23eda/recipes/vtu11/all/test_package/build/msvc-192-x86_64-14-release
    
    vtu11/1.2 (test package): Running CMake.build()
    vtu11/1.2 (test package): RUN: cmake --build "C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release" --config Release
    Microsoft (R) Build Engine version 16.11.2+f32259642 for .NET Framework
    Copyright (C) Microsoft Corporation. All rights reserved.
    
      Checking Build System
      Building Custom Rule C:/J/w/prod-v2/BuildSingleReference/cci-18d23eda/recipes/vtu11/all/test_package/CMakeLists.txt
      test_package.cpp
      The contents of <filesystem> are available only with C++17 or later.
    C:\J\w\prod-v2\BuildSingleReference\p\vtu11d67043759be5c\p\include\vtu11/inc/alias.hpp(45,30): error C2039: 'filesystem': is not a member of 'std' [C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\vector(24): message : see declaration of 'std' [C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    C:\J\w\prod-v2\BuildSingleReference\p\vtu11d67043759be5c\p\include\vtu11/inc/alias.hpp(45,40): error C2878: 'filesystem': a namespace or class of this name does not exist [C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    C:\J\w\prod-v2\BuildSingleReference\p\vtu11d67043759be5c\p\include\vtu11/impl/vtu11_impl.hpp(266,22): error C2653: 'vtu11fs': is not a class or namespace name [C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    C:\J\w\prod-v2\BuildSingleReference\p\vtu11d67043759be5c\p\include\vtu11/impl/vtu11_impl.hpp(266,36): error C3321: an initializer list is unexpected in this context [C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    C:\J\w\prod-v2\BuildSingleReference\p\vtu11d67043759be5c\p\include\vtu11/impl/vtu11_impl.hpp(266,31): error C2064: term does not evaluate to a function taking 1 arguments [C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    C:\J\w\prod-v2\BuildSingleReference\p\vtu11d67043759be5c\p\include\vtu11/impl/vtu11_impl.hpp(267,21): error C2653: 'vtu11fs': is not a class or namespace name [C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    C:\J\w\prod-v2\BuildSingleReference\p\vtu11d67043759be5c\p\include\vtu11/impl/vtu11_impl.hpp(267,35): error C3321: an initializer list is unexpected in this context [C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    C:\J\w\prod-v2\BuildSingleReference\p\vtu11d67043759be5c\p\include\vtu11/impl/vtu11_impl.hpp(267,30): error C2064: term does not evaluate to a function taking 1 arguments [C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    C:\J\w\prod-v2\BuildSingleReference\p\vtu11d67043759be5c\p\include\vtu11/impl/vtu11_impl.hpp(270,10): error C2653: 'vtu11fs': is not a class or namespace name [C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    C:\J\w\prod-v2\BuildSingleReference\p\vtu11d67043759be5c\p\include\vtu11/impl/vtu11_impl.hpp(270,7): error C3536: 'directory': cannot be used before it is initialized [C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    C:\J\w\prod-v2\BuildSingleReference\p\vtu11d67043759be5c\p\include\vtu11/impl/vtu11_impl.hpp(270,19): error C3861: 'exists': identifier not found [C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    C:\J\w\prod-v2\BuildSingleReference\p\vtu11d67043759be5c\p\include\vtu11/impl/vtu11_impl.hpp(272,9): error C2653: 'vtu11fs': is not a class or namespace name [C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    C:\J\w\prod-v2\BuildSingleReference\p\vtu11d67043759be5c\p\include\vtu11/impl/vtu11_impl.hpp(272,18): error C3861: 'create_directories': identifier not found [C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    C:\J\w\prod-v2\BuildSingleReference\p\vtu11d67043759be5c\p\include\vtu11/impl/vtu11_impl.hpp(277,35): error C3536: 'pvtufile': cannot be used before it is initialized [C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    C:\J\w\prod-v2\BuildSingleReference\p\vtu11d67043759be5c\p\include\vtu11/impl/vtu11_impl.hpp(277,13): error C2672: 'vtu11::detail::writeVTUFile': no matching overloaded function found [C:\J\w\prod-v2\BuildSingleReference\cci-18d23eda\recipes\vtu11\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    
    *********************************************************
    Recipe 'vtu11/1.2 (test package)' cannot build its binary
    It is possible that this recipe is not Conan 2.0 ready
    If the recipe comes from ConanCenter check: https://conan.io/cci-v2.html
    If it is your recipe, check if it is updated to 2.0
    *********************************************************
    
    ERROR: vtu11/1.2 (test package): Error in build() method, line 25
    	cmake.build()
    	ConanException: Error 1 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@conan-center-bot conan-center-bot merged commit b5eb62a into conan-io:master Apr 12, 2023
Comment on lines +52 to +53
if valid_min_cppstd(self, 17):
apply_conandata_patches(self)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this logic is wrong, specially when package id is cleared...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're correct, good catch. I'm a bit uncertain what the best way is to resolve this. What is your opinion? Should I solve this with a "custom" clear functionality in the package id, clearing everything except settings, compiler version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that the patch should be robust to any C++ standard in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a conan recipe for ease of use [request] vtu11/1.2.0
6 participants