-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mimalloc: add version 1.7.9, 2.0.9 #14931
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
This comment has been minimized.
This comment has been minimized.
recipes/mimalloc/all/conanfile.py
Outdated
@@ -144,6 +143,13 @@ def build(self): | |||
replace_in_file(self, os.path.join(self.source_folder, "CMakeLists.txt"), | |||
"mimalloc-redirect.lib", | |||
"mimalloc-redirect32.lib") | |||
if self.version in ["1.7.9", "2.0.9"]: | |||
replace_in_file(self, os.path.join(self.source_folder, "include", "mimalloc.h"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be a patch please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prince-chrismc
I agree with you!
I create patches for it.
recipes/mimalloc/all/conanfile.py
Outdated
replace_in_file(self, os.path.join(self.source_folder, "include", "mimalloc.h"), | ||
"template<class U> bool is_equal(const _mi_heap_stl_allocator_common<U, destroy>& x) const { return (this->heap == x.heap); }", | ||
"template<class U, bool b> bool is_equal(const _mi_heap_stl_allocator_common<U, b>& x) const { return (this->heap == x.heap); }") | ||
replace_in_file(self, os.path.join(self.source_folder, "include", "mimalloc.h"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be a patch please?
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
…-index into mimalloc-2.0.9
Conan v1 pipelineAll green in build 5 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* mimalloc: add version 1.7.9, 2.0.9 * fix compilation error on msvc * use self.settings instead self.info.settings Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * use self.settings instead of self.info.settings Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * create patches for older compilers --------- Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Specify library name and version: mimalloc/1.7.9,2.0.9