boost: conan v2 support #14415
Merged
boost: conan v2 support #14415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaceIm
force-pushed
the
boost-conan-v2
branch
from
9c37e04
to
35bb692
Compare
ghost
mentioned this pull request
|
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there. |
This was referenced Nov 24, 2022
SpaceIm
force-pushed
the
boost-conan-v2
branch
from
35bb692
to
e3dce93
Compare
1 task
|
FYI, there are some tricks to avoid to rely on conan v1 helpers: |
1 task
SpaceIm
commented
Nov 25, 2022
SpaceIm
force-pushed
the
boost-conan-v2
branch
6 times, most recently
from
68cd3fb
to
1e9996f
Compare
This comment has been minimized.
This comment has been minimized.
SpaceIm
force-pushed
the
boost-conan-v2
branch
2 times, most recently
from
32c6631
to
7b9a328
Compare
This comment has been minimized.
This comment has been minimized.
SpaceIm
force-pushed
the
boost-conan-v2
branch
2 times, most recently
from
0e15fc4
to
dadc295
Compare
SpaceIm
force-pushed
the
boost-conan-v2
branch
from
dadc295
to
af74024
Compare
|
So 2.0 does not work |
There was a problem hiding this comment.
I ran a few tests on my Mac book pro and had a few issues, the default one works but maybe you could try the ones that failed for me and let me know if it's on my end but seems theres a few edge cases
I'll try add test this one my windows + linux before I leave on vacation tomorrow if dear future me here's the commands I tested
5871 conan create all --version 1.80.0
5872 pip install conan==1.53
5873 conan create all boost/1.80.0@
5874 conan create all boost/1.80.0@ -s compiler.cppstd=17
5875 conan create all boost/1.80.0@ -o boost:header_only=True
5876 conan create all boost/1.80.0@ -o boost:without_regex=True
5877 conan create all boost/1.80.0@ -o boost:without_regex=True -o boost:without_iostreams
5878 conan create all boost/1.80.0@ -o boost:without_regex=True -o boost:without_iostreams=True
5879 conan create all boost/1.80.0@ -o boost:without_iostreams=True
5880 conan create all boost/1.80.0@ -o boost:without_coroutine=True`
jwillikers
previously approved these changes
Dec 8, 2022
Except |
|
I did not clear the test build folder 😵💫 yeah v2 does that for free now I didn't realize. Cheers, on my calendar I will circle back since this is important :) |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 0dd9649boost/1.79.0boost/1.78.0boost/1.76.0boost/1.72.0boost/1.80.0boost/1.75.0boost/1.71.0boost/1.74.0boost/1.70.0boost/1.77.0boost/1.73.0 |
Conan v1 pipelineAll green in build 18 (
|
Hooks produced the following warnings for commit 936eab0boost/1.78.0boost/1.80.0boost/1.79.0boost/1.77.0boost/1.74.0boost/1.70.0boost/1.76.0boost/1.75.0boost/1.73.0boost/1.72.0boost/1.71.0 |
jwillikers
approved these changes
Dec 11, 2022
|
I tested these combos on my mac and the results are as expected... Going to try this out on my windows this evening |
|
Windows testing |
prince-chrismc
approved these changes
Dec 14, 2022
|
I did the best I can testing this... if there are any breaks please help us fix them and document how to test them please! |
|
Just in time for 1.81.0 ? |
|
Hopefully! |
|
This change seems to break cross compilation of Boost with host profiles that uses CXX and CC variables in the [env] section of the profile (just like the documentation describes). |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!