boost: Add configure options #14625
Closed
boost: Add configure options #14625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sio_disable_serial_port, asio_no_experimental_string_view
ghost
mentioned this pull request
|
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This was referenced Dec 7, 2022
|
Do they change binaries? If they are just interface definitions not affecting compiled libraries, I don't see any interest to add these options. |
Conan v1 pipelineAll green in build 1 (
|
Hooks produced the following warnings for commit 5660e62boost/1.72.0boost/1.70.0boost/1.78.0boost/1.74.0boost/1.80.0boost/1.71.0boost/1.79.0boost/1.77.0boost/1.75.0boost/1.73.0boost/1.76.0 |
This was referenced Dec 16, 2022
Merged
Comment on lines
+1097
to
+1098
| if self.options.beast_use_std_string_view: | ||
| flags.append("define=BOOST_BEAST_USE_STD_STRING_VIEW=1") |
There was a problem hiding this comment.
My concern here is these change really quickly and managing them with each version is a pain boostorg/beast@7300ef4
This one is already deprecated 🙊
toge
approved these changes
Jan 25, 2023
|
This PR has been triggered again because there are existing changes in |
No opinion from anybody on this? |
prince-chrismc
suggested changes
Jan 25, 2023
3 tasks
|
The team discussed this issue and I've capture that decision in #15494. These options of options are generally not very beneficial as they can easily be set from profiles or downstream recipes. It might be possible that a define is too generic and must be set in a recipe to avoid propagation which would be a good technical reason to add these. The other practical reason is to much the upstream consumption model, assuming these are installed options. These options are expected to be injected by the consumer for the boost project so not going to be permitted in this particular. Hopefully that's a helpful explanation. |
|
Since is does not meet the criteria I will close this PR, feel free to reply if there's more information that was missed |
There's an official position in the PR mentioned above (finally) 🚀 should be pretty close to the status quo 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: boost/all
This adds the configuration options beast_use_std_string_view, asio_disable_eventfd, asio_disable_serial_port, asio_no_experimental_string_view.