boost: honor tools.build:compiler_executables config & env vars from [buildenv]
#14776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This was referenced Dec 16, 2022
SpaceIm
force-pushed
the
boost-honor-conf-compilers-executables
branch
from
b56e227
to
3a971bc
Compare
SpaceIm
changed the title
tools.build:compiler_executables configtools.build:compiler_executables config & env vars from [buildenv]
SpaceIm
force-pushed
the
boost-honor-conf-compilers-executables
branch
from
3a971bc
to
0a72b33
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 0a72b33boost/1.80.0boost/1.78.0boost/1.76.0boost/1.79.0boost/1.75.0boost/1.74.0boost/1.73.0boost/1.72.0boost/1.77.0boost/1.70.0boost/1.71.0 |
This was referenced Dec 19, 2022
Merged
| @@ -1161,7 +1161,8 @@ def _ranlib(self): | |||
|
|
|||
| @property | |||
| def _cxx(self): | |||
| cxx = self.buildenv.vars(self).get("CXX") | |||
| compilers_by_conf = self.conf.get("tools.build:compiler_executables", default={}, check_type=dict) | |||
| cxx = compilers_by_conf.get("cpp") or VirtualBuildEnv(self).vars().get("CXX") | |||
There was a problem hiding this comment.
I am not sure the 2.0 stuff should move forward with env vars or us the compilers from conf 🤔 but I think we can wait to see how that recommendation falls out
This matches with the explanation I got about how this feature works
prince-chrismc
approved these changes
Dec 27, 2022
|
Hum, CI was green for 11 days, but now it's red without useful feedback? I guess it's a consequence of #14888 merge in the meantime? |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipelineAll green in build 6 (
Conan v2 pipeline (informative, not required for merge)Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hooks produced the following warnings for commit a952484boost/1.79.0boost/1.77.0boost/1.75.0boost/1.74.0boost/1.73.0boost/1.72.0boost/1.71.0boost/1.70.0 |
|
@prince-chrismc @jwillikers could you approve again please? Bot seems to be confused. |
jwillikers
approved these changes
Dec 29, 2022
prince-chrismc
approved these changes
Dec 30, 2022
AbrilRBS
pushed a commit
to AbrilRBS/conan-center-index
that referenced
this pull request
Jan 16, 2023
…ig & env vars from `[buildenv]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14767
Honor
tools.build:compiler_executablesconfig introduced in conan 1.55.0, and properly listen env vars from profile[buildenv](self.buildenvdoesn't seem to be the correct attribute to listen).